Skip to content

bedrock: Optional pprof servers#3136

Merged
mergify[bot] merged 4 commits intodevelopfrom
jg/pprof
Jul 29, 2022
Merged

bedrock: Optional pprof servers#3136
mergify[bot] merged 4 commits intodevelopfrom
jg/pprof

Conversation

@trianglesphere
Copy link
Contributor

Description
This adds an optional pprof server to the op-node, op-batcher, & op-proposer.
The pprof server defaults to off & the address 0.0.0.0:6060. With docker compose,
it enables all of the pprof servers in the devnet with the following mapping:

  • op-node: 6060
  • op-batcher: 6061
  • op-proposer: 6062

Additional context

This only enables the default pprof servers. Further work is needed to run blocking
and mutex profiles. See https://pkg.go.dev/net/http/pprof

See the above details for a usage guide as well.

Metadata

  • Fixes ENG-2320
  • Fixes ENG-2322
  • Fixes ENG-2323
  • Fixes ENG-2324

@changeset-bot
Copy link

changeset-bot bot commented Jul 29, 2022

⚠️ No Changeset found

Latest commit: 2552c5f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify
Copy link
Contributor

mergify bot commented Jul 29, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

@trianglesphere trianglesphere changed the title Jg/pprof bedrock: Optional pprof servers Jul 29, 2022
@mergify
Copy link
Contributor

mergify bot commented Jul 29, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Jul 29, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit 2a7be36 into develop Jul 29, 2022
@mergify mergify bot deleted the jg/pprof branch July 29, 2022 22:27
@mergify mergify bot removed the on-merge-train label Jul 29, 2022
@mslipper mslipper mentioned this pull request Aug 4, 2022
maurelian pushed a commit that referenced this pull request Sep 15, 2022
* op-batcher: Enable optional pprof server

* op-proposer: Enable optional pprof server

* op-node: Eanble optional pprof server

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
sam-goldman pushed a commit that referenced this pull request Sep 15, 2022
* op-batcher: Enable optional pprof server

* op-proposer: Enable optional pprof server

* op-node: Eanble optional pprof server

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
theochap added a commit that referenced this pull request Jan 15, 2026
…idates only necessary blobs, and does not fallback to sidecars endpoint (op-rs/kona#3211)

Closes #3136

---------

Co-authored-by: theo <80177219+theochap@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants