contracts-bedrock: L2ToL1MessagePasser event extension#3135
Conversation
🦋 Changeset detectedLatest commit: 6e272fc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
2-reviewers
A-pkg-contracts-bedrock
|
I guess you need this here rather than the fixes repo because of the SDK? |
maurelian
left a comment
maurelian
left a comment
There was a problem hiding this comment.
Should add a test for this new event.
tynes
force-pushed
the
fix/contracts-event-extension
branch
from
7f23f19 to
55e195f
Compare
|
Hey @tynes! This PR has merge conflicts. Please fix them before continuing review. |
Emit an additional event during `initiateWithdrawal` that includes the withdrawal hash so that it is easy to observe changes to the `sentMessages` mapping.
tynes
force-pushed
the
fix/contracts-event-extension
branch
from
55e195f to
97e7345
Compare
tynes
force-pushed
the
fix/contracts-event-extension
branch
from
97e7345 to
5eb0f6f
Compare
protolambda
left a comment
protolambda
left a comment
There was a problem hiding this comment.
please keep the specs in sync
trianglesphere
left a comment
trianglesphere
left a comment
There was a problem hiding this comment.
go code's good. Adding to the specs would be nice as well.
tynes
force-pushed
the
fix/contracts-event-extension
branch
from
e805294 to
6e272fc
Compare
|
Not sure why the e2e tests hang when running in the cloud, they work fine locally edit: nvm seems like a flake or something, they worked now |
|
This PR has been added to the merge queue, and will be merged soon. |
4 participants
Description
Emit an additional event during
initiateWithdrawalthat includesthe withdrawal hash so that it is easy to observe changes to the
sentMessagesmapping.