op-node: Fixed Integers in channel frame header#3126
Merged
mergify[bot] merged 6 commits intodevelopfrom Aug 4, 2022
Merged
Conversation
|
Contributor
|
This PR changes implementation code, but doesn't include a changeset. Did you forget to add one? |
trianglesphere
force-pushed
the
jg/cleanup_channel_frame_serialization
branch
from
19f9215 to
d0d9a61
Compare
trianglesphere
force-pushed
the
jg/fixed_int
branch
from
bc6cd91 to
6ab970c
Compare
trianglesphere
force-pushed
the
jg/cleanup_channel_frame_serialization
branch
from
d0d9a61 to
6f9926c
Compare
Contributor
|
Hey @trianglesphere! This PR has merge conflicts. Please fix them before continuing review. |
trianglesphere
force-pushed
the
jg/fixed_int
branch
from
6ab970c to
c5cb400
Compare
trianglesphere
force-pushed
the
jg/cleanup_channel_frame_serialization
branch
from
6f9926c to
7539390
Compare
trianglesphere
force-pushed
the
jg/fixed_int
branch
from
c5cb400 to
ba2bb47
Compare
mslipper
reviewed
Aug 2, 2022
mslipper
reviewed
Aug 2, 2022
mslipper
approved these changes
Aug 2, 2022
Base automatically changed from
jg/cleanup_channel_frame_serialization
to
develop
August 2, 2022 20:08
Contributor
|
Hey @trianglesphere! This PR has merge conflicts. Please fix them before continuing review. |
protolambda
force-pushed
the
jg/fixed_int
branch
from
ba2bb47 to
0b93989
Compare
Contributor
|
Hey @trianglesphere! This PR has merge conflicts. Please fix them before continuing review. |
trianglesphere
commented
Aug 3, 2022
trianglesphere
force-pushed
the
jg/fixed_int
branch
from
b1b9914 to
4b53a5c
Compare
trianglesphere
force-pushed
the
jg/fixed_int
branch
from
4b53a5c to
7ab20bb
Compare
This mainly modifies the channel_frame, but has some knock on effects as the width of some of the fields have been reduced. The channel frame code is also changed more than I expected due to differences in API of working with fixed int vs uvarints in go. Otherwise the code reads very similarly with using Reader/Writer APIs.
trianglesphere
force-pushed
the
jg/fixed_int
branch
from
7ab20bb to
a694f3d
Compare
trianglesphere
force-pushed
the
jg/fixed_int
branch
from
a694f3d to
1212d38
Compare
tynes
reviewed
Aug 4, 2022
protolambda
reviewed
Aug 4, 2022
Contributor
protolambda
left a comment
protolambda
left a comment
There was a problem hiding this comment.
looks good, but not approving just yet to avoid auto-merge, one nit style fix first.
protolambda
approved these changes
Aug 4, 2022
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
roninjin10
pushed a commit
that referenced
this pull request
Aug 26, 2022
* goals for fixed int * op-node: Fixed integer sizes in the channel header This mainly modifies the channel_frame, but has some knock on effects as the width of some of the fields have been reduced. The channel frame code is also changed more than I expected due to differences in API of working with fixed int vs uvarints in go. Otherwise the code reads very similarly with using Reader/Writer APIs. * op-node: fix frame unmarshal func to return correct err * specs: update frame format specs * Update op-node/rollup/derive/channel_bank_test.go Co-authored-by: protolambda <proto@protolambda.com> Co-authored-by: Matthew Slipper <me@matthewslipper.com>
maurelian
pushed a commit
that referenced
this pull request
Sep 15, 2022
* goals for fixed int * op-node: Fixed integer sizes in the channel header This mainly modifies the channel_frame, but has some knock on effects as the width of some of the fields have been reduced. The channel frame code is also changed more than I expected due to differences in API of working with fixed int vs uvarints in go. Otherwise the code reads very similarly with using Reader/Writer APIs. * op-node: fix frame unmarshal func to return correct err * specs: update frame format specs * Update op-node/rollup/derive/channel_bank_test.go Co-authored-by: protolambda <proto@protolambda.com> Co-authored-by: Matthew Slipper <me@matthewslipper.com>
sam-goldman
pushed a commit
that referenced
this pull request
Sep 15, 2022
* goals for fixed int * op-node: Fixed integer sizes in the channel header This mainly modifies the channel_frame, but has some knock on effects as the width of some of the fields have been reduced. The channel frame code is also changed more than I expected due to differences in API of working with fixed int vs uvarints in go. Otherwise the code reads very similarly with using Reader/Writer APIs. * op-node: fix frame unmarshal func to return correct err * specs: update frame format specs * Update op-node/rollup/derive/channel_bank_test.go Co-authored-by: protolambda <proto@protolambda.com> Co-authored-by: Matthew Slipper <me@matthewslipper.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This switches the channel frame header over to using fixed integers. This avoids a circular
dependency when filling the serialized frame up to a maximum size. The circular dependency
is caused by the frame data length being a
uvarintwhich can vary in size when serialized.Metadata