Skip to content

ops: Properly set devnet batch submitter address#3121

Merged
mergify[bot] merged 2 commits intodevelopfrom
jg/fix_devnet_batcher_config
Jul 28, 2022
Merged

ops: Properly set devnet batch submitter address#3121
mergify[bot] merged 2 commits intodevelopfrom
jg/fix_devnet_batcher_config

Conversation

@trianglesphere
Copy link
Contributor

Description
This was being incorrectly set in the rollup json relative to the
HD path supplied to the batcher was. This resulted in L2 reorgs
on the sequencer & the inability to send L2 transactions.

This was being incorrectly set in the rollup json relative to the
HD path supplied to the batcher was. This resulted in L2 reorgs
on the sequencer & the inability to send L2 transactions.
@changeset-bot
Copy link

changeset-bot bot commented Jul 28, 2022

⚠️ No Changeset found

Latest commit: 52264a6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@trianglesphere trianglesphere requested review from mslipper and tynes July 28, 2022 19:10
@github-actions github-actions bot added 2-reviewers A-pkg-contracts-bedrock Area: packages/contracts-bedrock labels Jul 28, 2022
@mergify
Copy link
Contributor

mergify bot commented Jul 28, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

@mergify
Copy link
Contributor

mergify bot commented Jul 28, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify mergify bot merged commit 6c9862a into develop Jul 28, 2022
@mergify mergify bot deleted the jg/fix_devnet_batcher_config branch July 28, 2022 20:19
@mergify
Copy link
Contributor

mergify bot commented Jul 28, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the on-merge-train label Jul 28, 2022
@mslipper mslipper mentioned this pull request Aug 4, 2022
maurelian pushed a commit that referenced this pull request Sep 15, 2022
This was being incorrectly set in the rollup json relative to the
HD path supplied to the batcher was. This resulted in L2 reorgs
on the sequencer & the inability to send L2 transactions.

Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com>
sam-goldman pushed a commit that referenced this pull request Sep 15, 2022
This was being incorrectly set in the rollup json relative to the
HD path supplied to the batcher was. This resulted in L2 reorgs
on the sequencer & the inability to send L2 transactions.

Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com>
theochap pushed a commit that referenced this pull request Dec 10, 2025
Close #3100 by adding `admin_resetDerivationPipeline` RPC endpoint.

Followed the testing patterns from #3101, whole diff is not covered but
the core logic is.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-pkg-contracts-bedrock Area: packages/contracts-bedrock

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants