Skip to content

test(ctb): change gasLimit arg to uint256#3111

Merged
mergify[bot] merged 5 commits intodevelopfrom
m/debug-fuzz
Jul 29, 2022
Merged

test(ctb): change gasLimit arg to uint256#3111
mergify[bot] merged 5 commits intodevelopfrom
m/debug-fuzz

Conversation

@maurelian
Copy link
Contributor

Failing test case decodes to:

address _sender =  0xb4c79daB8f259C7Aee6E5b2Aa729821864227e84;
address _target = 0x028188030556FaF8383A2BA80d95E1415C6Ed6F6;
uint64 _value = 6060582089520090887;
uint8 _gasLimit = 164;
bytes memory _data = hex"945a53f5ffffffffffffffff0000000000000000000000000000000000000000";

Caveats:

  1. I'm really now sure how any of the tests passed with a maximum input of 255 for _gasLimit
  2. Even with this fix, if I locally do 512 runs, I still get a failure case with the following values:
address _sender =  0x0000000000000000000000000000000000000000;
address _target = 0x0000000000000000000000000000000000000000;
uint64 _value = 0;
uint256 _gasLimit = 8937393460516492772;
bytes memory _data = hex"0101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101010101";

Conclusion so far: it's got something to do with gasLimit.

@changeset-bot
Copy link

changeset-bot bot commented Jul 27, 2022

⚠️ No Changeset found

Latest commit: 3201262

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added 2-reviewers A-pkg-contracts-bedrock Area: packages/contracts-bedrock labels Jul 27, 2022
@mslipper
Copy link
Collaborator

Denet should be fixed after a rebase.

@maurelian maurelian requested a review from tynes July 28, 2022 18:43
@mergify
Copy link
Contributor

mergify bot commented Jul 29, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Jul 29, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit f1bcf4b into develop Jul 29, 2022
@mergify mergify bot deleted the m/debug-fuzz branch July 29, 2022 22:08
@mergify mergify bot removed the on-merge-train label Jul 29, 2022
@mslipper mslipper mentioned this pull request Aug 4, 2022
maurelian added a commit that referenced this pull request Sep 15, 2022
* test(ctb): change gasLimit arg to uint256

* test(ctb): Set maximum diff fuzz gasLimit to 30MM

* test(ctb): Set maximum diff fuzz value to 120MM eth

* ctb: Address compiler warnings

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
sam-goldman pushed a commit that referenced this pull request Sep 15, 2022
* test(ctb): change gasLimit arg to uint256

* test(ctb): Set maximum diff fuzz gasLimit to 30MM

* test(ctb): Set maximum diff fuzz value to 120MM eth

* ctb: Address compiler warnings

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-pkg-contracts-bedrock Area: packages/contracts-bedrock

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants