test(ctb): Add failure tests for finalizeWithdrawalTransaction#3089

Merged

maurelian merged 2 commits intodevelopfrom

m/test-finalizeWdTx

Jul 26, 2022

Contributor

maurelian commented Jul 25, 2022

Adds a test for each revert occurring in finalizeWithdrawalTransaction.

Fixes ENG-2474

changeset-bot bot commented Jul 25, 2022 •

edited

Loading

⚠️ No Changeset found

Latest commit: dc1d5e8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

maurelian force-pushed the m/test-finalizeWdTx branch from f8e64fc to bb69b3f Compare

July 25, 2022 15:20

github-actions bot added 2-reviewers A-pkg-contracts-bedrock labels

tynes reviewed

View reviewed changes

packages/contracts-bedrock/contracts/test/OptimismPortal.t.sol Outdated Show resolved Hide resolved

tynes reviewed

View reviewed changes

packages/contracts-bedrock/contracts/test/OptimismPortal.t.sol Show resolved Hide resolved

tynes reviewed

View reviewed changes

packages/contracts-bedrock/contracts/test/OptimismPortal.t.sol Show resolved Hide resolved

tynes reviewed

View reviewed changes

packages/contracts-bedrock/contracts/test/OptimismPortal.t.sol Outdated Show resolved Hide resolved

tynes reviewed

View reviewed changes

packages/contracts-bedrock/contracts/test/OptimismPortal.t.sol Show resolved Hide resolved

tynes reviewed

View reviewed changes

packages/contracts-bedrock/contracts/test/OptimismPortal.t.sol Outdated Show resolved Hide resolved

tynes requested changes

View reviewed changes

Contributor

tynes left a comment

Left a bunch of comments

maurelian force-pushed the m/test-finalizeWdTx branch 2 times, most recently from ffb321c to 202f8e2 Compare

July 26, 2022 13:42

maurelian requested a review from tynes

July 26, 2022 13:44

tynes approved these changes

View reviewed changes

maurelian force-pushed the m/test-finalizeWdTx branch from 202f8e2 to 2a76955 Compare

July 26, 2022 17:30

maurelian commented

View reviewed changes

packages/contracts-bedrock/contracts/test/OptimismPortal.t.sol Show resolved Hide resolved

Contributor

mergify bot commented Jul 26, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

github-actions bot added M-contracts A-op-bindings labels

maurelian added 2 commits

July 26, 2022 14:31


          test(ctb): Add failure tests for finalizeWithdrawalTransaction

3b2f061


          docs(ctb): Add comment regarding proxy address check

dc1d5e8

maurelian force-pushed the m/test-finalizeWdTx branch from 778b1fa to dc1d5e8 Compare

July 26, 2022 18:31

github-actions bot removed A-op-bindings M-contracts labels

protolambda approved these changes

View reviewed changes

maurelian merged commit 13a9e9b into develop

maurelian deleted the m/test-finalizeWdTx branch

July 26, 2022 18:55

Contributor

tynes commented Jul 27, 2022

Looks like CI found a counterexample:

[FAIL. Counterexample: calldata=0x9c7e352a000000000000000000000000b4c79dab8f259c7aee6e5b2aa729821864227e84000000000000000000000000028188030556faf8383a2ba80d95e1415c6ed6f6000000000000000000000000000000000000000000000000541b834cd1f08f0700000000000000000000000000000000000000000000000000000000000000a400000000000000000000000000000000000000000000000000000000000000a00000000000000000000000000000000000000000000000000000000000000020945a53f5ffffffffffffffff0000000000000000000000000000000000000000, args=[0xb4c79dab8f259c7aee6e5b2aa729821864227e84, 0x028188030556faf8383a2ba80d95e1415c6ed6f6, 6060582089520090887, 164, 0x945a53f5ffffffffffffffff0000000000000000000000000000000000000000]] test_finalizeWithdrawalTransaction_differential(address,address,uint64,uint8,bytes) (runs: 225, μ: 252441, ~: 266586)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-pkg-contracts-bedrock