feat(sdk): add Bedrock support to SDK#3086
Merged
mergify[bot] merged 9 commits intodevelopfrom Aug 2, 2022
Merged
Conversation
🦋 Changeset detectedLatest commit: 1389dd9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
2-reviewers
A-pkg-contracts-bedrock
Contributor
|
This PR changes implementation code, but doesn't include a changeset. Did you forget to add one? |
smartcontracts
force-pushed
the
sc/sdk-bedrock-2
branch
from
55096bf to
8742117
Compare
smartcontracts
changed the title
smartcontracts
force-pushed
the
sc/sdk-bedrock-2
branch
from
8742117 to
f7de637
Compare
Contributor
|
Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review. |
Contributor
|
Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review. |
Contributor
|
Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review. |
github-actions
bot
added
A-pkg-core-utils
Contributor
|
Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review. |
roninjin10
approved these changes
Aug 2, 2022
Contributor
roninjin10
left a comment
roninjin10
left a comment
There was a problem hiding this comment.
lgtm couple of nits but non blocking
mslipper
approved these changes
Aug 2, 2022
Collaborator
|
This looks good to me. @tynes if you want another set of eyes please have them review, then remove |
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
tynes
approved these changes
Aug 2, 2022
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Merged
roninjin10
pushed a commit
that referenced
this pull request
Aug 26, 2022
* core-utils: add bedrock types * sdk: implement bedrock functionality * tests: update for bedrock * sdk: add hardhat deposit task * circleci: run deposit task in ci * tsconfig: cleanup * contracts-bedrock: make commitment interval larger * changeset: add Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com>
maurelian
pushed a commit
that referenced
this pull request
Sep 15, 2022
* core-utils: add bedrock types * sdk: implement bedrock functionality * tests: update for bedrock * sdk: add hardhat deposit task * circleci: run deposit task in ci * tsconfig: cleanup * contracts-bedrock: make commitment interval larger * changeset: add Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com>
sam-goldman
pushed a commit
that referenced
this pull request
Sep 15, 2022
* core-utils: add bedrock types * sdk: implement bedrock functionality * tests: update for bedrock * sdk: add hardhat deposit task * circleci: run deposit task in ci * tsconfig: cleanup * contracts-bedrock: make commitment interval larger * changeset: add Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com>
nitaliano
pushed a commit
that referenced
this pull request
May 20, 2024
* core-utils: add bedrock types * sdk: implement bedrock functionality * tests: update for bedrock * sdk: add hardhat deposit task * circleci: run deposit task in ci * tsconfig: cleanup * contracts-bedrock: make commitment interval larger * changeset: add Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com>
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
The actor is split in two separate actors: `L1WatcherActor` and `L1QueryActor`. The `L1QueryActor` is promoted to a first-class actor and is now spawned from the main task. Each related `Context` and `State` structs are removed and the necessary fields are moved in to the actor's struct. For each actor an implementation of the builder pattern and custom error-types are provided. This makes it easier to apply inversion of control and do dependency injection. The construction of the actors has been moved downwards in `node.rs` to allow an incoming channel to be created before. Further, the `BlockStream` type has been isolated and rewritten to not use a reference but a clone of the L1 provider. ref: #3071
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the SDK to add support for Bedrock. Includes a minor fix to the
build pipeline for the contracts-bedrock package. Removes some utilities
that are now exported as part of core-utils.