feat(ctb): export ABI when building#3067
Merged
mergify[bot] merged 2 commits intodevelopfrom Jul 24, 2022
Merged
Conversation
🦋 Changeset detectedLatest commit: 7568f00 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
2-reviewers
A-pkg-contracts-bedrock
smartcontracts
force-pushed
the
sc/ctb-gen-artifacts
branch
2 times, most recently
from
287c96a to
11350d7
Compare
Updates the TypeScript build to also generate ABI objects that can be imported on the client-side. Specifically necessary so that these ABIs can be imported on the frontend where fs/glob is not available.
smartcontracts
force-pushed
the
sc/ctb-gen-artifacts
branch
from
11350d7 to
9bb9287
Compare
smartcontracts
requested review from
maurelian and
tynes
and removed request for
maurelian
tynes
approved these changes
Jul 24, 2022
Contributor
tynes
left a comment
tynes
left a comment
There was a problem hiding this comment.
Looks good to me, we could optimize the deps a bit in the future but for now this is good
mslipper
approved these changes
Jul 24, 2022
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
maurelian
pushed a commit
that referenced
this pull request
Sep 15, 2022
Updates the TypeScript build to also generate ABI objects that can be imported on the client-side. Specifically necessary so that these ABIs can be imported on the frontend where fs/glob is not available. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
sam-goldman
pushed a commit
that referenced
this pull request
Sep 15, 2022
Updates the TypeScript build to also generate ABI objects that can be imported on the client-side. Specifically necessary so that these ABIs can be imported on the frontend where fs/glob is not available. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Contributor
|
This is very ugly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the TypeScript build to also generate ABI objects that can be
imported on the client-side. Specifically necessary so that these ABIs
can be imported on the frontend where fs/glob is not available.