feat(ctb): introduce extra data event to XDM#3066
Merged
mergify[bot] merged 1 commit intodevelopfrom Jul 24, 2022
Merged
Conversation
🦋 Changeset detectedLatest commit: 9c598cf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
2-reviewers
A-pkg-contracts-bedrock
maurelian
reviewed
Jul 19, 2022
packages/contracts-bedrock/contracts/universal/CrossDomainMessenger.sol
Outdated
Show resolved
Hide resolved
smartcontracts
force-pushed
the
sc/ctb-extra-sent-message-data
branch
from
ef6e897 to
4818e29
Compare
tynes
approved these changes
Jul 19, 2022
Contributor
|
Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review. |
maurelian
approved these changes
Jul 19, 2022
Introduces a new SentMessageExtraData event to the CrossDomainMessenger base contract. We need this event so that we can properly find all relevant message data in the SDK. SDK cannot function without this event. We also cannot add to the old SentMessage event without breaking the ABI of our contract, so we're stuck adding an extra data event.
smartcontracts
force-pushed
the
sc/ctb-extra-sent-message-data
branch
from
4818e29 to
9c598cf
Compare
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
maurelian
pushed a commit
that referenced
this pull request
Sep 15, 2022
Introduces a new SentMessageExtraData event to the CrossDomainMessenger base contract. We need this event so that we can properly find all relevant message data in the SDK. SDK cannot function without this event. We also cannot add to the old SentMessage event without breaking the ABI of our contract, so we're stuck adding an extra data event.
sam-goldman
pushed a commit
that referenced
this pull request
Sep 15, 2022
Introduces a new SentMessageExtraData event to the CrossDomainMessenger base contract. We need this event so that we can properly find all relevant message data in the SDK. SDK cannot function without this event. We also cannot add to the old SentMessage event without breaking the ABI of our contract, so we're stuck adding an extra data event.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduces a new SentMessageExtraData event to the CrossDomainMessenger
base contract. We need this event so that we can properly find all
relevant message data in the SDK. SDK cannot function without this
event. We also cannot add to the old SentMessage event without breaking
the ABI of our contract, so we're stuck adding an extra data event.