Skip to content

fix(sdk): throw a better error for bad chain ID#3065

Merged
mergify[bot] merged 2 commits intodevelopfrom
sc/sdk-better-error
Jul 24, 2022
Merged

fix(sdk): throw a better error for bad chain ID#3065
mergify[bot] merged 2 commits intodevelopfrom
sc/sdk-better-error

Conversation

@smartcontracts
Copy link
Contributor

Description
Updates the SDK to throw a better error when the user provides a bad
chain ID. Would've helped an end-user more easily debug an issue where
the chain ID parameter was missing.

@changeset-bot
Copy link

changeset-bot bot commented Jul 19, 2022

🦋 Changeset detected

Latest commit: 954ab4c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@eth-optimism/sdk Patch
@eth-optimism/drippie-mon Patch
@eth-optimism/message-relayer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the A-pkg-sdk Area: packages/sdk label Jul 19, 2022
@smartcontracts
Copy link
Contributor Author

Need to fix a few bugs...

@smartcontracts smartcontracts force-pushed the sc/sdk-better-error branch 2 times, most recently from 52f66a1 to 9fb790e Compare July 19, 2022 13:47
Updates the SDK to throw a better error when the user provides a bad
chain ID. Would've helped an end-user more easily debug an issue where
the chain ID parameter was missing.
@smartcontracts smartcontracts requested a review from maurelian July 24, 2022 17:42
@mergify
Copy link
Contributor

mergify bot commented Jul 24, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Jul 24, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit 680714c into develop Jul 24, 2022
@mergify mergify bot deleted the sc/sdk-better-error branch July 24, 2022 19:33
@mergify mergify bot removed the on-merge-train label Jul 24, 2022
maurelian pushed a commit that referenced this pull request Sep 15, 2022
Updates the SDK to throw a better error when the user provides a bad
chain ID. Would've helped an end-user more easily debug an issue where
the chain ID parameter was missing.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
sam-goldman pushed a commit that referenced this pull request Sep 15, 2022
Updates the SDK to throw a better error when the user provides a bad
chain ID. Would've helped an end-user more easily debug an issue where
the chain ID parameter was missing.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
nitaliano pushed a commit that referenced this pull request May 20, 2024
Updates the SDK to throw a better error when the user provides a bad
chain ID. Would've helped an end-user more easily debug an issue where
the chain ID parameter was missing.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-pkg-sdk Area: packages/sdk

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants