specs: fix spec markdown linting#3061
Merged
mergify[bot] merged 4 commits intodevelopfrom Aug 3, 2022
Merged
Conversation
|
protolambda
force-pushed
the
lint-spec-md
branch
3 times, most recently
from
0d02fd1 to
fae2fc9
Compare
Contributor
Author
|
Won't merge this until I can get some feedback how to install the linting dependencies without affecting CI and the yarn/lerna setup negatively. |
Contributor
|
Hey @protolambda! This PR has merge conflicts. Please fix them before continuing review. |
maurelian
approved these changes
Jul 18, 2022
Contributor
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
style(specs): lint/toc/link fixes style(readme): fix bedrock contracts link chore(specs): specs lint scripts chore(specs): update CI jobs to use new lint scripts and unsilence links linter style(specs): fix toc, fix quotes in markdown lint script
protolambda
force-pushed
the
lint-spec-md
branch
from
7ff73b1 to
76c0397
Compare
protolambda
force-pushed
the
lint-spec-md
branch
from
b738436 to
da212a3
Compare
Contributor
Author
|
update: Fixed broken links, missing batcher spec, and misc lint issues. |
protolambda
force-pushed
the
lint-spec-md
branch
from
da212a3 to
7cdd7ac
Compare
mslipper
approved these changes
Aug 3, 2022
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Merged
roninjin10
pushed a commit
that referenced
this pull request
Aug 26, 2022
* style(specs): fix toc/lint in specs, update CI style(specs): lint/toc/link fixes style(readme): fix bedrock contracts link chore(specs): specs lint scripts chore(specs): update CI jobs to use new lint scripts and unsilence links linter style(specs): fix toc, fix quotes in markdown lint script * yarn: update linting dependencies * specs: add minimal batch submitter spec, fix broken links Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
maurelian
pushed a commit
that referenced
this pull request
Sep 15, 2022
* style(specs): fix toc/lint in specs, update CI style(specs): lint/toc/link fixes style(readme): fix bedrock contracts link chore(specs): specs lint scripts chore(specs): update CI jobs to use new lint scripts and unsilence links linter style(specs): fix toc, fix quotes in markdown lint script * yarn: update linting dependencies * specs: add minimal batch submitter spec, fix broken links Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
sam-goldman
pushed a commit
that referenced
this pull request
Sep 15, 2022
* style(specs): fix toc/lint in specs, update CI style(specs): lint/toc/link fixes style(readme): fix bedrock contracts link chore(specs): specs lint scripts chore(specs): update CI jobs to use new lint scripts and unsilence links linter style(specs): fix toc, fix quotes in markdown lint script * yarn: update linting dependencies * specs: add minimal batch submitter spec, fix broken links Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
theochap
added a commit
that referenced
this pull request
Dec 10, 2025
…3061) ## Description The finalization test was flaking because we didn't get enough new blocks finalized. This test ensures we are receiving at least one finalized block within 4 mins. --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous spec markdown had several undetected issues:
This PR:
doctocandmarkdownlint-cli2into the monorepodevDependenciesfor spec linting