Skip to content

contracts-bedrock: fix solhint ordering warnings#3058

Merged
maurelian merged 2 commits intoethereum-optimism:developfrom
lucadonnoh:develop
Jul 21, 2022
Merged

contracts-bedrock: fix solhint ordering warnings#3058
maurelian merged 2 commits intoethereum-optimism:developfrom
lucadonnoh:develop

Conversation

@lucadonnoh
Copy link
Contributor

@lucadonnoh lucadonnoh commented Jul 16, 2022 •
edited
Loading

Description
Fixed the ordering warnings across all contracts

Metadata

@changeset-bot
Copy link

changeset-bot bot commented Jul 16, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 45fc1b7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added 2-reviewers A-pkg-contracts-bedrock Area: packages/contracts-bedrock labels Jul 16, 2022
@mergify
Copy link
Contributor

mergify bot commented Jul 16, 2022

Hey @lucadonnoh! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Jul 16, 2022
@smartcontracts
Copy link
Contributor

smartcontracts commented Jul 19, 2022

Heyo @lucadonnoh looks like this just needs a quick rebase and conflict resolution. Will try to get reviewed ASAP to avoid further conflicts.

@lucadonnoh lucadonnoh closed this Jul 20, 2022
@github-actions github-actions bot removed A-pkg-contracts-bedrock Area: packages/contracts-bedrock 2-reviewers labels Jul 20, 2022
@mergify mergify bot removed the conflict label Jul 20, 2022
@lucadonnoh lucadonnoh reopened this Jul 20, 2022
@github-actions github-actions bot added 2-reviewers A-pkg-contracts-bedrock Area: packages/contracts-bedrock labels Jul 20, 2022
@maurelian maurelian mentioned this pull request Jul 21, 2022
Merged
@maurelian
Copy link
Contributor

maurelian commented Jul 21, 2022

@mergify refresh

@mergify
Copy link
Contributor

mergify bot commented Jul 21, 2022

refresh

✅ Pull request refreshed

@maurelian maurelian merged commit 1a47152 into ethereum-optimism:develop Jul 21, 2022
@maurelian
Copy link
Contributor

maurelian commented Jul 21, 2022

Got it in, thanks @lucadonnoh!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smartcontracts smartcontracts smartcontracts approved these changes

@maurelian maurelian maurelian approved these changes

Assignees

No one assigned

Labels

A-pkg-contracts-bedrock Area: packages/contracts-bedrock

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lucadonnoh @smartcontracts @maurelian