Skip to content

op-e2e: deploy output oracle with correct config (bedrock)#3056

Merged
mergify[bot] merged 1 commit intodevelopfrom
fix-op-e2e-output-time
Jul 15, 2022
Merged

op-e2e: deploy output oracle with correct config (bedrock)#3056
mergify[bot] merged 1 commit intodevelopfrom
fix-op-e2e-output-time

Conversation

@protolambda
Copy link
Contributor

@protolambda protolambda commented Jul 15, 2022

This PR:

  • deploys output oracle with correct config
  • de-duplicates block time and genesis setup info.

Previously the contract was being deployed with a block time of 2 instead of 1, and thus failing to confirm the latest outputs, and increasingly lagging behind the L2 chain.

@changeset-bot
Copy link

changeset-bot bot commented Jul 15, 2022

⚠️ No Changeset found

Latest commit: 6b2c89e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify
Copy link
Contributor

mergify bot commented Jul 15, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

@protolambda protolambda requested a review from tuxcanfly July 15, 2022 17:36
tuxcanfly
tuxcanfly approved these changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@tuxcanfly tuxcanfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

trianglesphere
trianglesphere approved these changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@trianglesphere trianglesphere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tysm for tracking this down

@mergify
Copy link
Contributor

mergify bot commented Jul 15, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify mergify bot merged commit b3264cf into develop Jul 15, 2022
@mergify mergify bot deleted the fix-op-e2e-output-time branch July 15, 2022 17:58
@mergify
Copy link
Contributor

mergify bot commented Jul 15, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the on-merge-train label Jul 15, 2022
theochap pushed a commit that referenced this pull request Dec 10, 2025
@soniseth0
chore(supervisor-storage): remove unused Debug import from log_provid…
e5f35a7 
…er (#3056)

Remove unused `std::fmt::Debug` import from `log_provider.rs`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@tuxcanfly tuxcanfly tuxcanfly approved these changes

@trianglesphere trianglesphere trianglesphere approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@protolambda @tuxcanfly @trianglesphere