Merged
Conversation
…with comments to clarify behavior
|
Contributor
|
This PR changes implementation code, but doesn't include a changeset. Did you forget to add one? |
tynes
approved these changes
Jul 14, 2022
trianglesphere
approved these changes
Jul 14, 2022
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
ChannelOut wasn't bumping its rlp_length counter after accepting a batch, so the per-channel RLP limit was enforced on stale numbers and input_bytes() lied about how much data went in. Now the counter increments as soon as the batch is written, so both the limit check and the reported stats match reality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the sequence window was 2 L1 blocks, each 2 seconds, so 4 seconds total. And it was taking 3+ seconds to confirm a tx. This caused batches to often get included too late, and force reorgs.
This PR increases the sequence window: eager batch queue processing will still keep the L2 chain running, but the tests shouldn't be as flaky anymore.
In a sepearate PR we can optimize the inclusion time of the batch transactions such that tests complete faster, but that's a different issue.
This PR also updates the missing-batch test with clarifying comments, and makes an exception there with sequence-window size, to not make the test longer than it needs to be.
And the batch-submitter was outputting a scary but harmless log at the start: that's not a reorg, that's the batch-submitter adopting the first safe-head. So I updated that log.