fix(ctb): Edit inaccurate comment about refunds#3045
Merged
mergify[bot] merged 2 commits intodevelopfrom Jul 14, 2022
Merged
Conversation
|
github-actions
bot
added
2-reviewers
A-pkg-contracts-bedrock
maurelian
commented
Jul 14, 2022
smartcontracts
approved these changes
Jul 14, 2022
tynes
approved these changes
Jul 14, 2022
Contributor
Author
|
@mergify refresh |
Contributor
✅ Pull request refreshed |
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
maurelian
force-pushed
the
m/ctb-bridge-comments
branch
from
8e123a2 to
b792ea5
Compare
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
# Summary This PR makes a number of actor-framework-level changes to allow dependency injection and ultimately unit tests within all of the actors. The actor that is used to demonstrate the updates is `SequencerActor`. If this approach looks good, issues can be created to update other actors and add test coverage. This also starts to create client traits for different actor functionality in an effort to remove channel dependencies at the interface level. This will help streamline unit tests and allow the interfaces to evolve more seamlessly. ## Key Changes * Loosen `NodeActor` trait requirements (remove `build()` fn and `builder` type) * Remove `RollupNodeService` trait since it had one implementation and logic split between trait and impl * Create traits for _most_ `SequencerActor` dependencies * This includes making facade client traits for actor-actor communication, loosening the interface-level dependence on channels and increasing unit testing ergonomics * The remaining dependencies will be wrapped in traits as a follow-up PR to this one to avoid further bulking this PR * Make `SequencerActor` generic over dependency traits * Inject concrete instances of dependencies into `SequencerActor` * Separate logic in `SequencerActor` into helper functions for better readability and self-documentation * Pull metrics, admin api server, error, and builder utilities into separate files to self-document and reduce size of main `SequencerActor` file --- Ref: #3025, #3021, #2623
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
This is a remnant from #3045 that should have been removed at that time, as all of its logic was pulled into service/node.rs. Thanks to @einar-oplabs for pointing this out!
theochap
pushed a commit
that referenced
this pull request
Jan 14, 2026
…kona#3129) This is a remnant from #3045 that should have been removed at that time, as all of its logic was pulled into service/node.rs. Thanks to @einar-oplabs for pointing this out!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.