Skip to content

op-node: conf depth filter should not filter out genesis#3042

Merged
mergify[bot] merged 1 commit intodevelopfrom
genesis-conf-depth-fix
Jul 14, 2022
Merged

op-node: conf depth filter should not filter out genesis#3042
mergify[bot] merged 1 commit intodevelopfrom
genesis-conf-depth-fix

Conversation

@protolambda
Copy link
Contributor

If we are requesting block 0 by number it must not be filtered out because of the confirmation depth filter, the genesis (even if below rollup genesis) always needs to be available as starting point.

@changeset-bot
Copy link

changeset-bot bot commented Jul 14, 2022

⚠️ No Changeset found

Latest commit: dfa1aa5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify
Copy link
Contributor

mergify bot commented Jul 14, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

@protolambda protolambda force-pushed the genesis-conf-depth-fix branch from a823773 to dfa1aa5 Compare July 14, 2022 17:22
@protolambda
Copy link
Contributor Author

Added a testcase

@mergify
Copy link
Contributor

mergify bot commented Jul 14, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify mergify bot merged commit f8c0148 into develop Jul 14, 2022
@mergify mergify bot deleted the genesis-conf-depth-fix branch July 14, 2022 18:27
@mergify
Copy link
Contributor

mergify bot commented Jul 14, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the on-merge-train label Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants