Skip to content

CTB: Pass arguments as calldata in bridge and messengers when possible#3038

Merged
mergify[bot] merged 1 commit intodevelopfrom
m/ctb-basegas-from-calldata
Jul 15, 2022
Merged

CTB: Pass arguments as calldata in bridge and messengers when possible#3038
mergify[bot] merged 1 commit intodevelopfrom
m/ctb-basegas-from-calldata

Conversation

@maurelian
Copy link
Contributor

@maurelian maurelian commented Jul 14, 2022

This saves about 200 gas when applied to baseGas.

The other changes in the xDM and bridge just feel like a best practice.

@changeset-bot
Copy link

changeset-bot bot commented Jul 14, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 613d8a6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added 2-reviewers C-protocol-critical Category: Modifies protocol-critical code A-pkg-contracts-bedrock Area: packages/contracts-bedrock labels Jul 14, 2022
@maurelian maurelian force-pushed the m/ctb-basegas-from-calldata branch from 1241842 to 3f07d1b Compare July 14, 2022 16:31
@github-actions github-actions bot removed C-protocol-critical Category: Modifies protocol-critical code M-contracts labels Jul 14, 2022
@maurelian maurelian requested a review from tynes July 14, 2022 17:15
@mergify
Copy link
Contributor

mergify bot commented Jul 14, 2022

Hey @maurelian! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Jul 14, 2022
@maurelian maurelian force-pushed the m/ctb-basegas-from-calldata branch from 3f07d1b to b0ec624 Compare July 14, 2022 20:14
@mergify mergify bot removed the conflict label Jul 14, 2022
@mergify
Copy link
Contributor

mergify bot commented Jul 14, 2022

Hey @maurelian! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Jul 14, 2022
@maurelian maurelian force-pushed the m/ctb-basegas-from-calldata branch from b0ec624 to 613d8a6 Compare July 14, 2022 23:36
@mergify mergify bot removed the conflict label Jul 14, 2022
@maurelian
Copy link
Contributor Author

maurelian commented Jul 15, 2022

@mergify refresh

@mergify
Copy link
Contributor

mergify bot commented Jul 15, 2022

refresh

✅ Pull request refreshed

@mergify
Copy link
Contributor

mergify bot commented Jul 15, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify mergify bot merged commit 7baf49f into develop Jul 15, 2022
@mergify mergify bot deleted the m/ctb-basegas-from-calldata branch July 15, 2022 02:22
@mergify
Copy link
Contributor

mergify bot commented Jul 15, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the on-merge-train label Jul 15, 2022
theochap added a commit that referenced this pull request Dec 10, 2025
@Galoretka @theochap
Reduce redundant Arc clones in proof L1 pipeline initialization (#3038)
24bcabc 
- Replaced .rollup_config(cfg.clone()) with .rollup_config(cfg) and
introduced a single pre-clone cfg_for_reset used for the reset’s
system_config_by_number call.
- Passed l1_cfg by move to StatefulAttributesBuilder::new instead of
cloning since it’s not used afterward.
- This reduces minor allocations and aligns with established patterns
(see crates/providers/providers-alloy/src/pipeline.rs), without changing
behavior or ownership semantics.

Co-authored-by: theo <80177219+theochap@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tynes tynes tynes approved these changes

@smartcontracts smartcontracts smartcontracts approved these changes

Assignees

No one assigned

Labels

A-pkg-contracts-bedrock Area: packages/contracts-bedrock

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maurelian @tynes @smartcontracts