Skip to content

test(ctb): add test for stuck ETH on failed msg#3029

Merged
mergify[bot] merged 4 commits intodevelopfrom
sc/ctb-relay-eth-test
Jul 14, 2022
Merged

test(ctb): add test for stuck ETH on failed msg#3029
mergify[bot] merged 4 commits intodevelopfrom
sc/ctb-relay-eth-test

Conversation

@smartcontracts
Copy link
Contributor

Description
Adds a test that ETH gets properly stuck in the CrossDomainMessenger
contracts but then is unstuck when the message is replayed.

@github-actions github-actions bot added 2-reviewers A-pkg-contracts-bedrock Area: packages/contracts-bedrock labels Jul 13, 2022
@tynes
Copy link
Contributor

tynes commented Jul 13, 2022


Learn more at https://hardhat.org/reference/solidity-support

Error HH701: There are multiple artifacts for contract "Reverter", please use a fully qualified name.

Please replace Reverter for one of these options wherever you are trying to read its artifact:

L1CrossDomainMessenger.t.sol:Reverter
L2CrossDomainMessenger.t.sol:Reverter

@smartcontracts smartcontracts force-pushed the sc/ctb-relay-eth-test branch from c6ec1ed to aa8c1f7 Compare July 13, 2022 21:14
@changeset-bot
Copy link

changeset-bot bot commented Jul 13, 2022

⚠️ No Changeset found

Latest commit: 961230e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify
Copy link
Contributor

mergify bot commented Jul 13, 2022

Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Jul 13, 2022
Adds a test that ETH gets properly stuck in the CrossDomainMessenger
contracts but then is unstuck when the message is replayed.
@smartcontracts smartcontracts force-pushed the sc/ctb-relay-eth-test branch from aa8c1f7 to cb4ccbb Compare July 13, 2022 22:13
@mergify mergify bot removed the conflict label Jul 13, 2022
@mergify
Copy link
Contributor

mergify bot commented Jul 14, 2022

Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Jul 14, 2022
@mergify mergify bot removed the conflict label Jul 14, 2022
@mergify
Copy link
Contributor

mergify bot commented Jul 14, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Jul 14, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit 301b518 into develop Jul 14, 2022
@mergify mergify bot deleted the sc/ctb-relay-eth-test branch July 14, 2022 14:18
@mergify mergify bot removed the on-merge-train label Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-pkg-contracts-bedrock Area: packages/contracts-bedrock

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants