style(ctb): fix revert messages globally#3005

Merged

mergify[bot] merged 1 commit intodevelopfrom

sc/ctb-fix-reverts

Jul 14, 2022

Contributor

smartcontracts commented Jul 13, 2022 •

edited

Loading

Description
Updates revert messages across all contracts to use the standardized
format "ContractName: lowercase message".

changeset-bot bot commented Jul 13, 2022 •

edited

Loading

🦋 Changeset detected

Latest commit: a80f9c6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@eth-optimism/contracts-bedrock	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions bot added 2-reviewers A-pkg-contracts-bedrock labels

tynes reviewed

View reviewed changes

packages/contracts-bedrock/contracts/universal/OptimismMintableERC20Factory.sol Show resolved Hide resolved

Contributor

tynes commented Jul 13, 2022

Looks like a linting error

smartcontracts force-pushed the sc/ctb-fix-reverts branch from 6de90d3 to 9de2ecb Compare

July 13, 2022 15:10

smartcontracts requested a review from maurelian

July 13, 2022 15:10

maurelian approved these changes

View reviewed changes

smartcontracts force-pushed the sc/ctb-fix-reverts branch from 9de2ecb to c3646ae Compare

July 13, 2022 17:15

Contributor

mergify bot commented Jul 13, 2022

Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review.

mergify bot added the conflict label

smartcontracts force-pushed the sc/ctb-fix-reverts branch from c3646ae to 09135da Compare

July 13, 2022 17:44

mergify bot removed the conflict label

smartcontracts force-pushed the sc/ctb-fix-reverts branch from 09135da to 35fa5c2 Compare

July 13, 2022 19:45

tynes approved these changes

View reviewed changes

Contributor

mergify bot commented Jul 13, 2022

Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review.

mergify bot added the conflict label

smartcontracts force-pushed the sc/ctb-fix-reverts branch from 35fa5c2 to 66587bf Compare

July 13, 2022 21:05

mergify bot removed the conflict label

smartcontracts force-pushed the sc/ctb-fix-reverts branch from 66587bf to ce6a684 Compare

July 13, 2022 21:07

Contributor

mergify bot commented Jul 13, 2022

Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review.

mergify bot added the conflict label

smartcontracts force-pushed the sc/ctb-fix-reverts branch from ce6a684 to a99ea64 Compare

July 13, 2022 21:37

mergify bot removed the conflict label

Contributor

mergify bot commented Jul 13, 2022

Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review.

mergify bot added the conflict label

smartcontracts force-pushed the sc/ctb-fix-reverts branch from a99ea64 to f966a5f Compare

July 13, 2022 22:16

mergify bot removed the conflict label

Contributor

mergify bot commented Jul 14, 2022

Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review.

mergify bot added the conflict label

smartcontracts force-pushed the sc/ctb-fix-reverts branch from 29c4361 to a132696 Compare

July 14, 2022 15:26

mergify bot removed the conflict label

smartcontracts force-pushed the sc/ctb-fix-reverts branch from a132696 to ee8abb9 Compare

July 14, 2022 15:32

Contributor

trianglesphere commented Jul 14, 2022

I'm getting very similar issues when running locally. I don't think it's flaky test for this

Contributor

mergify bot commented Jul 14, 2022

Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review.

mergify bot added the conflict label

smartcontracts force-pushed the sc/ctb-fix-reverts branch from ee8abb9 to 3933e34 Compare

July 14, 2022 19:32

mergify bot removed the conflict label

smartcontracts force-pushed the sc/ctb-fix-reverts branch from 3933e34 to af8ad87 Compare

July 14, 2022 21:00

Contributor

mergify bot commented Jul 14, 2022

Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review.

mergify bot added the conflict label


          style(ctb): fix revert messages globally

a80f9c6

Updates revert messages across all contracts to use the standardized
format "<ContractName>: <lowercase message>".

smartcontracts force-pushed the sc/ctb-fix-reverts branch from af8ad87 to a80f9c6 Compare

July 14, 2022 21:17

mergify bot removed the conflict label

Contributor

mergify bot commented Jul 14, 2022

This PR has been added to the merge queue, and will be merged soon.

mergify bot added the on-merge-train label

mergify bot merged commit 1a22e82 into develop

mergify bot deleted the sc/ctb-fix-reverts branch

July 14, 2022 21:28

Contributor

mergify bot commented Jul 14, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

mergify bot removed the on-merge-train label

theochap added a commit that referenced this pull request


          Remove unused SingleBatch::has_invalid_transactions helper (#3005)

## Summary
- remove the unused `SingleBatch::has_invalid_transactions` helper that
duplicates the checks in `check_batch`
- reduce dead code noise in `SingleBatch`

Co-authored-by: theo <80177219+theochap@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-pkg-contracts-bedrock