Closed
Conversation
|
maurelian
force-pushed
the
m/test-deploy-ci
branch
from
7fe55ee to
4b7affa
Compare
kick build
maurelian
force-pushed
the
m/test-deploy-ci
branch
from
4b7affa to
9f3a0b8
Compare
theochap
added a commit
that referenced
this pull request
Dec 10, 2025
The RPC configuration had a confusing semantic mismatch between the CLI flag and environment variable. The flag `--rpc.disabled` expects a boolean to disable RPC when true, but the environment variable was named `KONA_NODE_RPC_ENABLED` which suggests the opposite behavior. This caused user confusion where setting `KONA_NODE_RPC_ENABLED=true` would actually disable the RPC server instead of enabling it. Users naturally expect an "ENABLED" variable to enable functionality when set to true. Changed the environment variable from `KONA_NODE_RPC_ENABLED` to `KONA_NODE_RPC_DISABLED` to match the CLI flag semantics. Also updated the comment from "Whether to enable" to "Whether to disable" for consistency. Co-authored-by: theo <80177219+theochap@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a deploy step to each of the contracts packages:
Even if the full devnet integration tests are not running in CI, this will be helpful for ensuring that the deploy scripts are working.