Skip to content

contracts-bedrock: fix some compiler warnings#2839

Merged
mergify[bot] merged 1 commit intodevelopfrom
fix/compiler-warnings
Jul 7, 2022
Merged

contracts-bedrock: fix some compiler warnings#2839
mergify[bot] merged 1 commit intodevelopfrom
fix/compiler-warnings

Conversation

@tynes
Copy link
Contributor

@tynes tynes commented Jun 22, 2022

Description
This PR fixes some of the compiler warnings emitted when compiling contracts-bedrock. There are more compiler warnings, but this gets some of the higher priority/low hanging fruit

@changeset-bot
Copy link

changeset-bot bot commented Jun 22, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 654b2d8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eth-optimism/contracts-bedrock Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

maurelian
maurelian approved these changes Jun 28, 2022
View reviewed changes
@mergify
Copy link
Contributor

mergify bot commented Jul 6, 2022

Hey @tynes! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Jul 6, 2022
@tynes tynes force-pushed the fix/compiler-warnings branch from c2dea80 to 3e627a5 Compare July 6, 2022 19:15
@github-actions github-actions bot added 2-reviewers A-pkg-contracts-bedrock Area: packages/contracts-bedrock labels Jul 6, 2022
@mergify mergify bot removed the conflict label Jul 6, 2022
@mergify
Copy link
Contributor

mergify bot commented Jul 7, 2022

Hey @tynes! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Jul 7, 2022
@tynes tynes force-pushed the fix/compiler-warnings branch from f060b62 to b073f83 Compare July 7, 2022 00:54
@mergify mergify bot removed the conflict label Jul 7, 2022
@mergify
Copy link
Contributor

mergify bot commented Jul 7, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Jul 7, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the on-merge-train label Jul 7, 2022
@mergify
Copy link
Contributor

mergify bot commented Jul 7, 2022

Merge failed. Please see automated check logs for more details.

@tynes
contracts-bedrock: fix some compiler warnings
654b2d8 
also regenerate `op-bindings`
@tynes tynes force-pushed the fix/compiler-warnings branch from d21f648 to 654b2d8 Compare July 7, 2022 05:38
@mergify
Copy link
Contributor

mergify bot commented Jul 7, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify mergify bot merged commit 7180050 into develop Jul 7, 2022
@mergify mergify bot deleted the fix/compiler-warnings branch July 7, 2022 05:54
@mergify
Copy link
Contributor

mergify bot commented Jul 7, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the on-merge-train label Jul 7, 2022
theochap added a commit that referenced this pull request Dec 10, 2025
@theochap
chore(node/deps): update rocksdb version (#2839)
bfb8a70 
## Description

Per title, should allow to fix #2437
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mslipper mslipper mslipper approved these changes

@maurelian maurelian maurelian approved these changes

Assignees

No one assigned

Labels

A-pkg-contracts-bedrock Area: packages/contracts-bedrock

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tynes @mslipper @maurelian