Skip to content

proxyd: Use canned response for eth_accounts#2801

Merged
mergify[bot] merged 2 commits intodevelopfrom
feat/proxyd-eth-accounts-block
Jun 16, 2022
Merged

proxyd: Use canned response for eth_accounts#2801
mergify[bot] merged 2 commits intodevelopfrom
feat/proxyd-eth-accounts-block

Conversation

@mslipper
Copy link
Contributor

We never want to expose Geth's accounts to the public internet, so proxyd will now return [] for eth_accounts RPC calls without hitting the backend.

We never want to expose Geth's accounts to the public internet, so proxyd will now return `[]` for `eth_accounts` RPC calls without hitting the backend.
@changeset-bot
Copy link

changeset-bot bot commented Jun 16, 2022

🦋 Changeset detected

Latest commit: 6ea4e8c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eth-optimism/proxyd Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mslipper mslipper requested review from Inphi and optimisticben June 16, 2022 17:26
Copy link
Contributor

@optimisticben optimisticben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lmtm

Copy link
Contributor

@Inphi Inphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Super nit incoming:
However, this makes proxyd even more specific to our infrastructure. A couple folks have expressed interest into using proxyd for generic JSON-RPC routing. I dunno if anyone else deploys proxyd for other networks, but this would be a surprising change in behavior.

@mergify
Copy link
Contributor

mergify bot commented Jun 16, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Jun 16, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit 063c55c into develop Jun 16, 2022
@mergify mergify bot deleted the feat/proxyd-eth-accounts-block branch June 16, 2022 19:02
@mergify mergify bot removed the on-merge-train label Jun 16, 2022
@optimisticben
Copy link
Contributor

Super nit incoming: However, this makes proxyd even more specific to our infrastructure. A couple folks have expressed interest into using proxyd for generic JSON-RPC routing. I dunno if anyone else deploys proxyd for other networks, but this would be a surprising change in behavior.

That's a good point. This should be behind a feature flag tbh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants