proxyd: Use canned response for eth_accounts#2801
Conversation
We never want to expose Geth's accounts to the public internet, so proxyd will now return `[]` for `eth_accounts` RPC calls without hitting the backend.
🦋 Changeset detectedLatest commit: 6ea4e8c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Inphi
left a comment
There was a problem hiding this comment.
Looks good.
Super nit incoming:
However, this makes proxyd even more specific to our infrastructure. A couple folks have expressed interest into using proxyd for generic JSON-RPC routing. I dunno if anyone else deploys proxyd for other networks, but this would be a surprising change in behavior.
|
This PR has been added to the merge queue, and will be merged soon. |
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
That's a good point. This should be behind a feature flag tbh. |
We never want to expose Geth's accounts to the public internet, so proxyd will now return
[]foreth_accountsRPC calls without hitting the backend.