ci: Fix broken js-builder build#2784
Merged
mergify[bot] merged 2 commits intodevelopfrom Jun 15, 2022
Merged
Conversation
The curl commands weren't outputting files and the checksum verification was breaking other commands.
🦋 Changeset detectedLatest commit: 426d4a1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
smartcontracts
approved these changes
Jun 15, 2022
Inphi
approved these changes
Jun 15, 2022
Contributor
Inphi
left a comment
Inphi
left a comment
There was a problem hiding this comment.
Looks good.
But i'm curious as to how it worked before if the curl command download anything?
Collaborator
Author
|
I don't think it did - check out the build logs: https://app.circleci.com/pipelines/github/ethereum-optimism/optimism/3161/workflows/210e526a-625c-43e6-acf0-bfb56ab8a543/jobs/38071 |
Collaborator
Author
|
@Mergifyio refresh |
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
✅ Pull request refreshed |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
tynes
approved these changes
Jun 15, 2022
Merged
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
Closes #2741 --------- Co-authored-by: sadiq1971 <sadiqurr8@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The curl commands weren't outputting files and the checksum verification was breaking other commands.