bedrock: fix OZ-H-O2 Token address ordering#2778
Merged
mergify[bot] merged 3 commits intodevelopfrom Jun 14, 2022
Merged
Conversation
🦋 Changeset detectedLatest commit: 5deb916 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
maurelian
force-pushed
the
m/oz-h-02-develop
branch
2 times, most recently
from
e396a96 to
01a515d
Compare
maurelian
commented
Jun 14, 2022
maurelian
requested review from
smartcontracts and
tynes
and removed request for
mslipper and
tuxcanfly
Contributor
|
It appears as if this change doesn't cause any tests to fail - it would be ideal to add a unit test that would fail without the change and then passes with the change |
maurelian
force-pushed
the
m/oz-h-02-develop
branch
from
01a515d to
2390b96
Compare
Contributor
Author
|
@tynes Added that test. |
maurelian
force-pushed
the
m/oz-h-02-develop
branch
from
2390b96 to
9557da8
Compare
smartcontracts
approved these changes
Jun 14, 2022
tynes
approved these changes
Jun 14, 2022
This change addresses the H-O2 finding in the OZ audit extension.
maurelian
force-pushed
the
m/oz-h-02-develop
branch
from
9557da8 to
081b889
Compare
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change addresses the H-O2 finding in the OZ audit extension.
This PR is on develop. I've merged the same fixes to the bedrock branch in #2779.