Skip to content

Comments

Goerli devnet replicas#2774

Merged
mergify[bot] merged 7 commits intodevelopfrom
goerli-devnet-replicas
Jun 14, 2022
Merged

Goerli devnet replicas#2774
mergify[bot] merged 7 commits intodevelopfrom
goerli-devnet-replicas

Conversation

@optimisticben
Copy link
Contributor

@optimisticben optimisticben commented Jun 14, 2022

Description
Lots of yaml for Goerli devnet L1 and L2 replicas, in cluster.

@optimisticben optimisticben requested review from mslipper and tynes June 14, 2022 11:54
@changeset-bot
Copy link

changeset-bot bot commented Jun 14, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: d5e2911

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@optimisticben optimisticben marked this pull request as ready for review June 14, 2022 11:54
@mergify mergify bot requested review from Inphi and tuxcanfly June 14, 2022 11:54
tynes
tynes approved these changes Jun 14, 2022
View reviewed changes
Copy link
Contributor

@tynes tynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some deprecated config, you can verify using git grep -r <env-var> and see that its not consumed by l2geth or the dockerfile entrypoints, since its all in this repo

@tynes
Copy link
Contributor

tynes commented Jun 14, 2022

I don't think pruning out the deprecated config across the entire repo is very high priority unless you find it particularly annoying since bedrock deployments will be done from scratch

@mslipper
Copy link
Collaborator

mslipper commented Jun 14, 2022

Let's ignore the deprecated configs until Bedrock.

@mergify
Copy link
Contributor

mergify bot commented Jun 14, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Jun 14, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit 6c9a87a into develop Jun 14, 2022
@mergify mergify bot deleted the goerli-devnet-replicas branch June 14, 2022 22:31
@mergify mergify bot removed the on-merge-train label Jun 14, 2022
@mslipper mslipper mentioned this pull request Jun 18, 2022
Merged
theochap pushed a commit that referenced this pull request Dec 10, 2025
@itschaindev
chore (supervisor): build info in metrics (#2774)
451ebcd 
Closes #2760 

The Overview now looks like:

<img width="1705" height="427" alt="Screenshot 2025-08-26 at 19 30 52"
src="https://github.com/user-attachments/assets/aad99ab1-2f4d-48b8-99e3-31e1e4b17522"
/>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mslipper mslipper mslipper approved these changes

@tynes tynes tynes approved these changes

@Inphi Inphi Awaiting requested review from Inphi

@tuxcanfly tuxcanfly Awaiting requested review from tuxcanfly

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@optimisticben @tynes @mslipper