Bedrock: share more test utils, cleanup derive package structure, move payload/attributes types to eth package#2761
Conversation
…ine types from l2 to eth package
… for public use, split payload_attributes and improve file names
…s into shared package
|
|
This PR changes implementation code, but doesn't include a changeset. Did you forget to add one? |
trianglesphere
left a comment
trianglesphere
left a comment
There was a problem hiding this comment.
Restructure looks good to me.
Only weird thing are some of the imports. I'm fine addressing them now w/out needing re-review or addressing them in a follow up PR.
norswap
left a comment
norswap
left a comment
There was a problem hiding this comment.
Looks good to me, definitely a step in the right direction!
|
This PR has been added to the merge queue, and will be merged soon. |
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
…e payload/attributes types to eth package (#2761) * feat(bedrock): move ExecutionPayload, PayloadAttributes and other engine types from l2 to eth package * chore(bedrock): clean up derive package, move test util out or polish for public use, split payload_attributes and improve file names * chore(bedrock): move more test utils out of derive and driver packages into shared package * bedrock: fix go import newlines/order * testutils: describe TestID usage Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
…e payload/attributes types to eth package (#2761) * feat(bedrock): move ExecutionPayload, PayloadAttributes and other engine types from l2 to eth package * chore(bedrock): clean up derive package, move test util out or polish for public use, split payload_attributes and improve file names * chore(bedrock): move more test utils out of derive and driver packages into shared package * bedrock: fix go import newlines/order * testutils: describe TestID usage Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
…t rpc call (#2761) ## Description It seems the `opp2p_disconnect` rpc call returns too early. This method ensures that we're checking the peers are effectively not connected to each other in the `opp2p_peers` call.
3 participants
No changes or additions in functionality in this PR. These changes aim to clean up the structure/naming of the
derivepackage in preparation of the upcoming batch derivation changes, and usage in Cannon.Changes:
ExecutionPayload,PayloadAttributes, and related API response types to theethpackage.ethitself), without circular dependenciesEngineinterface that the driver code uses, to substitute the external engine with an in-memory EVM (with pre-image-oracle based state db) to run the fraud proof with.payload_attributes.go: it didn't even contain the payload attributes type, and it was a mixed bag of things.GenerateDepositLogfunction is nowMarshalDepositLogEvent, since it nicely mirrorsUnmarshalDepositLogEvent(slight rename from previousUnmarshalLogEvent) and we need it to be exposed for testing in other packages. This can't be part of the test util package, since the test-util package does not pull in anything fromderive(since it's used for testingderiveitself)testID(to easily createeth.BlockIDwith in tests) to test utils package