Conversation
|
|
This PR changes implementation code, but doesn't include a changeset. Did you forget to add one? |
![semgrep-app[bot]](https://avatars.githubusercontent.com/in/60555?s=60&v=4){kind=small}
| case <-ticker.C: | ||
| case <-time.After(100 * time.Millisecond): | ||
| } | ||
| } |
There was a problem hiding this comment.
Leaky use of time.After in for-select (Lines 32-45)
🔴 Fix or ignore this finding to merge your pull request.
🙈 From dgryski.semgrep-go.timeafter.leaky-time-after.
| select { | ||
| case <-ticker.C: | ||
| case <-time.After(s.cfg.PollInterval): | ||
| // Determine the range of L2 blocks that the submitter has not |
There was a problem hiding this comment.
Leaky use of time.After in for-select (Lines 105-171)
🔴 Fix or ignore this finding to merge your pull request.
🙈 From dgryski.semgrep-go.timeafter.leaky-time-after.
| // price and publish a new transaction. | ||
| case <-ticker.C: | ||
| case <-time.After(m.cfg.ResubmissionTimeout): | ||
| // Avoid republishing if we are waiting for confirmation on an |
There was a problem hiding this comment.
Leaky use of time.After in for-select (Lines 208-235)
🔴 Fix or ignore this finding to merge your pull request.
🙈 From dgryski.semgrep-go.timeafter.leaky-time-after.
Closes #2714 and #2713 Dashboard preview: <img width="1845" height="281" alt="Screenshot 2025-08-20 at 15 43 45" src="https://github.com/user-attachments/assets/101c7cb2-f900-40fa-b708-6277930d11e2" /> This should also work with other Kona services.
1 participant
Description
A clear and concise description of the features you're adding in this pull request.
Additional context
Add any other context about the problem you're solving.
Metadata