feat(cmn): have BSV2 export metadata metrics#2736
Merged
mergify[bot] merged 1 commit intodevelopfrom Jun 9, 2022
Merged
Conversation
🦋 Changeset detectedLatest commit: 57b7ed9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
smartcontracts
force-pushed
the
sc/cmn-bs-version-metric
branch
from
14d3f59 to
c35c79a
Compare
Updates BaseServiceV2 to require a version string. Also now exports parameters in a synthetic metric but ignores any parameters explicitly marked secret.
smartcontracts
force-pushed
the
sc/cmn-bs-version-metric
branch
from
c35c79a to
57b7ed9
Compare
tynes
approved these changes
Jun 9, 2022
roninjin10
approved these changes
Jun 9, 2022
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
roninjin10
reviewed
Jun 9, 2022
| this.metrics.metadata.set( | ||
| { | ||
| // eslint-disable-next-line @typescript-eslint/no-var-requires | ||
| version: require('../package.json').version, |
Contributor
There was a problem hiding this comment.
nice, definitely way more readable to do it this way
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
This was referenced Jun 9, 2022
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates BaseServiceV2 to require a version string. Also now exports
parameters in a synthetic metric but ignores any parameters explicitly
marked secret.