feat(cmn): have BaseService expose a full server#2725
Merged
mergify[bot] merged 1 commit intodevelopfrom Jun 9, 2022
Merged
Conversation
🦋 Changeset detectedLatest commit: 4021ee9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
smartcontracts
force-pushed
the
sc/cmn-bs-server
branch
from
bc05688 to
b44ec41
Compare
smartcontracts
force-pushed
the
sc/cmn-bs-server
branch
from
b44ec41 to
f7b9874
Compare
mslipper
approved these changes
Jun 9, 2022
roninjin10
suggested changes
Jun 9, 2022
roninjin10
force-pushed
the
sc/cmn-bs-server
branch
from
f7b9874 to
f9e47a0
Compare
smartcontracts
force-pushed
the
sc/cmn-bs-server
branch
from
f9e47a0 to
528bfd7
Compare
roninjin10
approved these changes
Jun 9, 2022
Updates BaseServiceV2 to expose a full server instead of simply exposing the server for metrics. Services can now add new custom routes to this server. Mainly useful because we're already running the metrics server, so we might as well allow people to add more things to it.
roninjin10
force-pushed
the
sc/cmn-bs-server
branch
from
528bfd7 to
4021ee9
Compare
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
roninjin10
pushed a commit
that referenced
this pull request
Jun 9, 2022
Updates BaseServiceV2 to expose a full server instead of simply exposing the server for metrics. Services can now add new custom routes to this server. Mainly useful because we're already running the metrics server, so we might as well allow people to add more things to it.
This was referenced Jun 9, 2022
Merged
Merged
Merged
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
theochap
pushed a commit
that referenced
this pull request
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates BaseServiceV2 to expose a full server instead of simply exposing
the server for metrics. Services can now add new custom routes to this
server. Mainly useful because we're already running the metrics server,
so we might as well allow people to add more things to it.
Requested by @roninjin10