feat(sdk): add support for Bedrock by smartcontracts · Pull Request #2701 · ethereum-optimism/optimism

smartcontracts · 2022-06-06T22:03:12Z

Description
Adds support for Bedrock behind a bedrock flag. Specifically updates how
events are queried, hashed, and relayed.

changeset-bot · 2022-06-06T22:03:14Z

🦋 Changeset detected

Latest commit: 6be5e79

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages

Name	Type
@eth-optimism/sdk	Minor
@eth-optimism/contracts-bedrock	Patch
@eth-optimism/drippie-mon	Patch
@eth-optimism/message-relayer	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

smartcontracts · 2022-06-06T23:16:42Z

packages/sdk/src/utils/contracts.ts

      CanonicalTransactionChain:
        '0x5E4e65926BA27467555EB562121fac00D24E9dD2' as const,
      BondManager: '0xcd626E1328b41fCF24737F137BcD4CE0c32bc8d1' as const,
+      OptimismPortal: '0x0000000000000000000000000000000000000000' as const,


Will need to replace these addresses once they've been deployed

packages/sdk/src/utils/contracts.ts

packages/sdk/src/utils/message-encoding.ts

packages/contracts-bedrock/contracts/universal/CrossDomainMessenger.sol

smartcontracts · 2022-06-07T01:15:21Z

packages/contracts-bedrock/contracts/universal/CrossDomainMessenger.sol

        );

        emit SentMessage(_target, msg.sender, _message, messageNonce(), _minGasLimit);
+        emit SentMessageExtraData(msg.sender, msg.value);


SentMessage is a legacy event that shouldn't be changed so we can preserve the interface. Instead of adding a completely new event, we add SentMessageExtraData.

smartcontracts · 2022-06-07T05:17:06Z

CI issue driving me crazy, will fix tomorrow

tynes · 2022-06-08T19:51:27Z

Not sure why this error is happening, my guess its a bad import path or something about the docker build in CI

#27 218.1 src/utils/contracts.ts(3,47): error TS2307: Cannot find module '@eth-optimism/contracts-bedrock/artifacts/contracts/universal/CrossDomainMessenger.sol/CrossDomainMessenger.json' or its corresponding type declarations.

Skipping flaky geth tests here: #2720

Could look at .dockerignore to be sure artifacts isn't in it

mergify · 2022-06-08T20:52:56Z

Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review.

mergify · 2022-06-14T22:48:48Z

Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review.

mergify · 2022-06-28T19:48:12Z

Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review.

mergify · 2022-06-28T23:11:11Z

Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review.

Adds a SentMessageV2 event to the XDM which includes all relevant information in the sent message and properly indexes the sender address.

Adds support for Bedrock behind a bedrock flag. Specifically updates how events are queried, hashed, and relayed.

### Description P2P Peer Scoring Example in the docs. Progress on #2581

github-actions bot added the A-pkg-sdk Area: packages/sdk label Jun 6, 2022

smartcontracts force-pushed the sc/sdk-bedrock branch 4 times, most recently from 5434991 to 9984163 Compare June 6, 2022 23:11

smartcontracts commented Jun 6, 2022

View reviewed changes

packages/sdk/src/utils/contracts.ts Show resolved Hide resolved

smartcontracts commented Jun 6, 2022

View reviewed changes

packages/sdk/src/utils/message-encoding.ts Show resolved Hide resolved

smartcontracts force-pushed the sc/sdk-bedrock branch 2 times, most recently from 680694a to bb8b28d Compare June 6, 2022 23:31

smartcontracts commented Jun 7, 2022

View reviewed changes

packages/contracts-bedrock/contracts/universal/CrossDomainMessenger.sol Outdated Show resolved Hide resolved

smartcontracts force-pushed the sc/sdk-bedrock branch from bb8b28d to 881083c Compare June 7, 2022 01:09

smartcontracts commented Jun 7, 2022

View reviewed changes

smartcontracts force-pushed the sc/sdk-bedrock branch 3 times, most recently from 9dd1059 to c522919 Compare June 7, 2022 03:36

mergify bot added conflict and removed conflict labels Jun 8, 2022

smartcontracts force-pushed the sc/sdk-bedrock branch 2 times, most recently from 52bd275 to 78778bd Compare June 14, 2022 20:10

mergify bot added the conflict label Jun 14, 2022

smartcontracts force-pushed the sc/sdk-bedrock branch from 78778bd to c27a72a Compare June 27, 2022 17:42

mergify bot removed the conflict label Jun 27, 2022

smartcontracts force-pushed the sc/sdk-bedrock branch 2 times, most recently from 5284f03 to 045e19d Compare June 27, 2022 21:35

smartcontracts force-pushed the sc/sdk-bedrock branch 6 times, most recently from 28a7488 to bb0e7bb Compare June 28, 2022 19:39

mergify bot added the conflict label Jun 28, 2022

smartcontracts force-pushed the sc/sdk-bedrock branch 2 times, most recently from 710f566 to e3153a3 Compare June 28, 2022 19:57

mergify bot removed the conflict label Jun 28, 2022

smartcontracts force-pushed the sc/sdk-bedrock branch 3 times, most recently from 7f32954 to 5554f33 Compare June 28, 2022 21:20

mergify bot added the conflict label Jun 28, 2022

smartcontracts added 6 commits June 29, 2022 13:10

feat(ctb): add SentMessageV2 event to XDM

fa02c10

Adds a SentMessageV2 event to the XDM which includes all relevant information in the sent message and properly indexes the sender address.

feat(sdk): add support for Bedrock

ca3c2fd

Adds support for Bedrock behind a bedrock flag. Specifically updates how events are queried, hashed, and relayed.

wip: various bugs

daca0e4

wip: fixs

beeeacc

wip

f87b03b

wip

6be5e79

smartcontracts force-pushed the sc/sdk-bedrock branch from 5554f33 to 6be5e79 Compare June 29, 2022 17:10

mergify bot removed the conflict label Jun 29, 2022

smartcontracts closed this Jun 29, 2022

smartcontracts deleted the sc/sdk-bedrock branch August 18, 2022 15:23

theochap pushed a commit that referenced this pull request Dec 10, 2025

feat(docs): P2P Scoring Example (#2701)

14a7de8

### Description P2P Peer Scoring Example in the docs. Progress on #2581

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(sdk): add support for Bedrock#2701

feat(sdk): add support for Bedrock#2701
smartcontracts wants to merge 6 commits intodevelopfrom
sc/sdk-bedrock

smartcontracts commented Jun 6, 2022

Uh oh!

changeset-bot bot commented Jun 6, 2022 •

edited

Loading

Uh oh!

smartcontracts Jun 6, 2022 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

smartcontracts Jun 7, 2022

Uh oh!

smartcontracts commented Jun 7, 2022

Uh oh!

tynes commented Jun 8, 2022 •

edited

Loading

Uh oh!

mergify bot commented Jun 8, 2022

Uh oh!

mergify bot commented Jun 14, 2022

Uh oh!

mergify bot commented Jun 28, 2022

Uh oh!

mergify bot commented Jun 28, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

smartcontracts commented Jun 6, 2022

Uh oh!

changeset-bot bot commented Jun 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

smartcontracts Jun 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

smartcontracts Jun 7, 2022

Choose a reason for hiding this comment

Uh oh!

smartcontracts commented Jun 7, 2022

Uh oh!

tynes commented Jun 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mergify bot commented Jun 8, 2022

Uh oh!

mergify bot commented Jun 14, 2022

Uh oh!

mergify bot commented Jun 28, 2022

Uh oh!

mergify bot commented Jun 28, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

changeset-bot bot commented Jun 6, 2022 •

edited

Loading

smartcontracts Jun 6, 2022 •

edited

Loading

tynes commented Jun 8, 2022 •

edited

Loading