Skip to content

teleportr: Improve metrics#2690

Merged
mergify[bot] merged 2 commits intoethereum-optimism:developfrom
mslipper:feat/teleportr-better-metrics
Jun 6, 2022
Merged

teleportr: Improve metrics#2690
mergify[bot] merged 2 commits intoethereum-optimism:developfrom
mslipper:feat/teleportr-better-metrics

Conversation

@mslipper
Copy link
Collaborator

@mslipper mslipper commented Jun 6, 2022

  • Update metrics collection to happen on an interval in addition to on each tick of the driver loop. This lets us continue collecting on-chain metrics if the driver loop halts for some reason.
  • Adds an additional metric to track the last on-chian deposit ID. This will let add Teleportr halting alerts more easily.

@changeset-bot
Copy link

changeset-bot bot commented Jun 6, 2022

🦋 Changeset detected

Latest commit: eef5df1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eth-optimism/teleportr Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mergify
Copy link
Contributor

mergify bot commented Jun 6, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

@mslipper mslipper force-pushed the feat/teleportr-better-metrics branch from 5dc1669 to 7c84978 Compare June 6, 2022 03:58
@mslipper mslipper force-pushed the feat/teleportr-better-metrics branch from 7c84978 to 329f320 Compare June 6, 2022 14:36
Copy link
Contributor

@Inphi Inphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- Update metrics collection to happen on an interval in addition to on each tick of the driver loop. This lets us continue collecting on-chain metrics if the driver loop halts for some reason.
- Adds an additional metric to track the last on-chian deposit ID. This will let add Teleportr halting alerts more easily.
@mslipper mslipper force-pushed the feat/teleportr-better-metrics branch from 329f320 to 1cefad1 Compare June 6, 2022 15:00
Copy link
Contributor

@tuxcanfly tuxcanfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

@mergify
Copy link
Contributor

mergify bot commented Jun 6, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify mergify bot merged commit 487a973 into ethereum-optimism:develop Jun 6, 2022
@mergify
Copy link
Contributor

mergify bot commented Jun 6, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants