devnet: Fix devnet#2684
Merged
mergify[bot] merged 2 commits intoethereum-optimism:developfrom Jun 6, 2022
Merged
Conversation
|
mslipper
force-pushed
the
feat/devnet-fixed
branch
2 times, most recently
from
2231524 to
bdd2e97
Compare
mslipper
force-pushed
the
feat/devnet-fixed
branch
from
bdd2e97 to
709d769
Compare
Inphi
approved these changes
Jun 5, 2022
Contributor
Inphi
left a comment
Inphi
left a comment
There was a problem hiding this comment.
looks good. Though removing images that match a glob can be surprising to users that build custom images (myself included) with a matching glob. It would be better if we removed specific image names. But this is acceptable too.
tynes
approved these changes
Jun 6, 2022
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Merged
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
theochap
pushed a commit
that referenced
this pull request
Jan 15, 2026
## Summary This PR replicates the changes from alloy-rs/alloy#2684 for the OpExecutionPayload types, adding `into_block_raw()` methods to centralize block construction logic and eliminate code duplication. ## Changes - Added `into_block_raw()` method to `OpExecutionPayloadV4` that converts the payload to a block with raw transactions - Added `into_block_raw()` method to `OpExecutionPayload` enum that delegates to the appropriate variant - Added `into_block_with_sidecar_raw()` method to `OpExecutionPayload` for creating blocks with sidecar data - Refactored `try_into_block_with` and `try_into_block_with_sidecar_with` methods to use the new raw methods combined with `Block::try_map_transactions` ## Motivation The alloy PR #2684 introduced these methods to provide a cleaner API and reduce code duplication. By using `into_block_raw()` methods that return blocks with raw transaction bytes, we can then use `Block::try_map_transactions` to convert them to any transaction type, making the code more maintainable and flexible. ## Notes - The implementation properly handles the fact that upstream alloy types return `Result<Block<Bytes>, PayloadError>` from their `into_block_raw` methods - All existing validation logic for Optimism-specific requirements (empty L1 withdrawals, no blob transactions) is preserved - Tests pass and formatting has been applied
theochap
pushed a commit
that referenced
this pull request
Jan 21, 2026
…s/op-alloy#570) ## Summary This PR replicates the changes from alloy-rs/alloy#2684 for the OpExecutionPayload types, adding `into_block_raw()` methods to centralize block construction logic and eliminate code duplication. ## Changes - Added `into_block_raw()` method to `OpExecutionPayloadV4` that converts the payload to a block with raw transactions - Added `into_block_raw()` method to `OpExecutionPayload` enum that delegates to the appropriate variant - Added `into_block_with_sidecar_raw()` method to `OpExecutionPayload` for creating blocks with sidecar data - Refactored `try_into_block_with` and `try_into_block_with_sidecar_with` methods to use the new raw methods combined with `Block::try_map_transactions` ## Motivation The alloy PR #2684 introduced these methods to provide a cleaner API and reduce code duplication. By using `into_block_raw()` methods that return blocks with raw transaction bytes, we can then use `Block::try_map_transactions` to convert them to any transaction type, making the code more maintainable and flexible. ## Notes - The implementation properly handles the fact that upstream alloy types return `Result<Block<Bytes>, PayloadError>` from their `into_block_raw` methods - All existing validation logic for Optimism-specific requirements (empty L1 withdrawals, no blob transactions) is preserved - Tests pass and formatting has been applied
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.