Skip to content

core-utils: update geth genesis type#2661

Merged
tynes merged 2 commits intodevelopfrom
fix/geth-types
Jun 2, 2022
Merged

core-utils: update geth genesis type#2661
tynes merged 2 commits intodevelopfrom
fix/geth-types

Conversation

@tynes
Copy link
Contributor

@tynes tynes commented Jun 2, 2022

Can specify the private key in the json file which
is nice for testing

Description
Updates core-utils to have updated geth types that make building a genesis block more easy

Can specify the private key in the json file which
is nice for testing
@changeset-bot
Copy link

changeset-bot bot commented Jun 2, 2022

🦋 Changeset detected

Latest commit: 5ecdd80

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@eth-optimism/core-utils Patch
@eth-optimism/common-ts Patch
@eth-optimism/contracts Patch
@eth-optimism/data-transport-layer Patch
@eth-optimism/message-relayer Patch
@eth-optimism/replica-healthcheck Patch
@eth-optimism/sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the A-pkg-core-utils Area: packages/core-utils label Jun 2, 2022
@mslipper
Copy link
Collaborator

mslipper commented Jun 2, 2022

LGTM, but shouldn't it be a major release if we're doing a backwards-incompatible API change?

@mergify
Copy link
Contributor

mergify bot commented Jun 2, 2022

This PR has been added to the merge queue, and will be merged soon.

@tynes
Copy link
Contributor Author

tynes commented Jun 2, 2022

LGTM, but shouldn't it be a major release if we're doing a backwards-incompatible API change?

The new values are optional as noted by ?

@mergify
Copy link
Contributor

mergify bot commented Jun 2, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@tynes tynes merged commit 3172720 into develop Jun 2, 2022
@tynes tynes deleted the fix/geth-types branch June 2, 2022 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-pkg-core-utils Area: packages/core-utils

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants