l2geth: verifier sync in parallel with dtl#2656
l2geth: verifier sync in parallel with dtl#2656mergify[bot] merged 2 commits intoethereum-optimism:developfrom
Conversation
🦋 Changeset detectedLatest commit: 197a5c8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
smartcontracts
left a comment
There was a problem hiding this comment.
I have successfully synced an L1-syncing node with this change. We should try to sync an L2-syncing node as well.
|
So this definitely works for L1 sync. Maybe we can just enable this feature for L1 sync for now? L2 sync is generally much faster, so this is less necessary. |
I think this should also work when syncing from L2, we would just need to confirm that it is the case it does work by trying it out |
|
I'd really like to get this merged, but I haven't had the opportunity to test on L2-syncing nodes. L1 syncing nodes is where I really care about this anyway because the DTL is so much slower. In the interest of speed, let's just have the IF statement be: |
6f8e722 to
8cf1016
Compare
smartcontracts
left a comment
There was a problem hiding this comment.
Can confirm that this properly syncs an L1-syncing node
|
cc @tynes do you mind dropping one quick review here |
|
@tonykogias just needs a quick rebase |
|
This PR has been added to the merge queue, and will be merged soon. |
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
|
Eyyyyyy SO glad this is live now |
Have verifier node sync in parallel with dtl to save time.
Metadata