Skip to content

fix(l2geth): L1 sync error recovery logic#2647

Merged
mergify[bot] merged 1 commit intodevelopfrom
sc/l2g-l1-sync-recovery
Jun 1, 2022
Merged

fix(l2geth): L1 sync error recovery logic#2647
mergify[bot] merged 1 commit intodevelopfrom
sc/l2g-l1-sync-recovery

Conversation

@smartcontracts
Copy link
Contributor

Description
Adds logic to startup that will attempt to recover from situations in
which a DTL batch was skipped. Specifically meant to allow existing L1
syncing nodes to continue to sync after the recent DTL bug.

@github-actions github-actions bot added 2-reviewers C-protocol-critical Category: Modifies protocol-critical code A-cannon Area: cannon labels Jun 1, 2022
@mergify mergify bot requested a review from tynes June 1, 2022 15:42
@smartcontracts smartcontracts force-pushed the sc/l2g-l1-sync-recovery branch from 3abf0bc to 7fd9660 Compare June 1, 2022 15:49
@changeset-bot
Copy link

changeset-bot bot commented Jun 1, 2022

🦋 Changeset detected

Latest commit: 75af33a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eth-optimism/l2geth Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@smartcontracts smartcontracts force-pushed the sc/l2g-l1-sync-recovery branch 2 times, most recently from 0799818 to 03df84b Compare June 1, 2022 15:55
@tynes
Copy link
Contributor

tynes commented Jun 1, 2022

rollup/sync_service_test.go:971:19: cannot use client (variable of type *mockClient) as type RollupClient in assignment:

Adds logic to startup that will attempt to recover from situations in
which a DTL batch was skipped. Specifically meant to allow existing L1
syncing nodes to continue to sync after the recent DTL bug.
@smartcontracts smartcontracts force-pushed the sc/l2g-l1-sync-recovery branch from 03df84b to 75af33a Compare June 1, 2022 16:39
@mergify
Copy link
Contributor

mergify bot commented Jun 1, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify mergify bot merged commit 359bc60 into develop Jun 1, 2022
@mergify mergify bot deleted the sc/l2g-l1-sync-recovery branch June 1, 2022 16:53
@mergify
Copy link
Contributor

mergify bot commented Jun 1, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cannon Area: cannon C-protocol-critical Category: Modifies protocol-critical code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants