Skip to content

opnode: Record errors from batch derivation#2636

Merged
mergify[bot] merged 2 commits intodevelopfrom
jg/tob_9
Jun 2, 2022
Merged

opnode: Record errors from batch derivation#2636
mergify[bot] merged 2 commits intodevelopfrom
jg/tob_9

Conversation

@trianglesphere
Copy link
Contributor

Description
Errors were not being logged. Note that we keep processing in the
presence of batch derivation errors as we do not trust this L1 input
to always be valid.

Metadata

  • Fixes ENG-2151

@changeset-bot
Copy link

changeset-bot bot commented May 31, 2022

⚠️ No Changeset found

Latest commit: 634c625

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify mergify bot requested review from Inphi and tuxcanfly May 31, 2022 20:54
@mergify
Copy link
Contributor

mergify bot commented May 31, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

Copy link
Contributor

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok, you may want to remove the unnecessary if.

Errors were not being logged. Note that we keep processing in the
presence of batch derivation errors as we do not trust this L1 input
to always be valid.
Copy link
Contributor

@tynes tynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, not sure if an invalid sender is technically an error case, we could be able to skip that one. We do want to know about invalid batches for sure

@mergify
Copy link
Contributor

mergify bot commented Jun 2, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify mergify bot merged commit 7689966 into develop Jun 2, 2022
@mergify mergify bot deleted the jg/tob_9 branch June 2, 2022 21:54
@mergify
Copy link
Contributor

mergify bot commented Jun 2, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants