opnode: Record errors from batch derivation#2636
Conversation
|
|
This PR changes implementation code, but doesn't include a changeset. Did you forget to add one? |
protolambda
left a comment
There was a problem hiding this comment.
looks ok, you may want to remove the unnecessary if.
Errors were not being logged. Note that we keep processing in the presence of batch derivation errors as we do not trust this L1 input to always be valid.
tynes
left a comment
There was a problem hiding this comment.
Looks good to me, not sure if an invalid sender is technically an error case, we could be able to skip that one. We do want to know about invalid batches for sure
|
This PR has been added to the merge queue, and will be merged soon. |
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Description
Errors were not being logged. Note that we keep processing in the
presence of batch derivation errors as we do not trust this L1 input
to always be valid.
Metadata