fix: l2geth-exporter docker build#2633
Merged
mergify[bot] merged 2 commits intodevelopfrom Jun 1, 2022
Merged
Conversation
Fixes the docker build for `l2geth-exporter`
|
Inphi
approved these changes
Jun 1, 2022
tuxcanfly
approved these changes
Jun 1, 2022
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
**Context** Kurtosis’s built-in reverse proxy automatically creates host-based routes only for service ports flagged with an HTTP application protocol. In other words, if a service’s port is marked as application_protocol = "http" (or "https"), Kurtosis will generate a URL (host route) for it. If a port is left as a raw TCP/UDP port with no HTTP protocol designation, the reverse proxy won’t create a host route for it. In the Ethereum package’s default configuration, Geth’s JSON-RPC port 8545 isn’t explicitly labeled as an HTTP port, so Kurtosis isn’t routing it through the reverse proxy by default. (It’s still accessible via the container’s exposed port or an ephemeral host port, but not under the port-service-enclave host domain.) For running the e2e tests with devstack it's mandatory that routes for L1Network has to be added to the kurtosis reverse proxy container. There’s no built-in user parameter or manifest setting in the Ethereum package to toggle the port’s protocol – the package’s Starlark code defines the ports internally. However, you can work around this by updating the service configuration after the package is running. The go-optimism is doing exactly the same thing after deploying devnet. It re-applying the routes by adding those ports as well. This setup was missing here in kona.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the docker build for
l2geth-exporter