fix(fd): start at beginning of challenge period#2629
Conversation
🦋 Changeset detectedLatest commit: d33b7af The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
How exactly are you testing this? |
smartcontracts
force-pushed
the
sc/fd-better-start
branch
from
fdc80b3 to
36f2d02
Compare
Added tests |
smartcontracts
force-pushed
the
sc/fd-better-start
branch
from
36f2d02 to
bdc759a
Compare
|
Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review. |
smartcontracts
force-pushed
the
sc/fd-better-start
branch
from
bdc759a to
ef2ee2d
Compare
|
Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review. |
smartcontracts
force-pushed
the
sc/fd-better-start
branch
from
ef2ee2d to
7d30b6f
Compare
|
Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review. |
smartcontracts
force-pushed
the
sc/fd-better-start
branch
from
7d30b6f to
0601eae
Compare
|
@smartcontracts This looks like it needs a rebase |
smartcontracts
force-pushed
the
sc/fd-better-start
branch
from
0601eae to
604f8ad
Compare
|
Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review. |
smartcontracts
force-pushed
the
sc/fd-better-start
branch
from
604f8ad to
8006d95
Compare
smartcontracts
force-pushed
the
sc/fd-better-start
branch
from
8006d95 to
c93336b
Compare
Updates the fault-detector to use a smarter starting height by default. Specifically, the fault-detector will now start at the first batch that has not yet crossed the challenge period, since the general trust assumption is that invalid batches will not pass the challenge period. Significantly reduces verification time, especially since the fault detector is stateless and does not keep track of the highest verified batch.
smartcontracts
force-pushed
the
sc/fd-better-start
branch
from
c93336b to
d024f0b
Compare
|
This PR has been added to the merge queue, and will be merged soon. |
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
|
Merge failed. Please see automated check logs for more details. |
|
This PR has been added to the merge queue, and will be merged soon. |
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Updates the fault-detector to use a smarter starting height by default. Specifically, the fault-detector will now start at the first batch that has not yet crossed the challenge period, since the general trust assumption is that invalid batches will not pass the challenge period. Significantly reduces verification time, especially since the fault detector is stateless and does not keep track of the highest verified batch. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
## Overview Updates the `mips64` target specification to work with the latest nightly release of `rustc`.
3 participants
Description
Updates the fault-detector to use a smarter starting height by default.
Specifically, the fault-detector will now start at the first batch that
has not yet crossed the challenge period, since the general trust
assumption is that invalid batches will not pass the challenge period.
Significantly reduces verification time, especially since the fault
detector is stateless and does not keep track of the highest verified
batch.