Skip to content

feat(ctp): introduce Drippie#2569

Merged
mergify[bot] merged 1 commit intodevelopfrom
sc/drip
Jun 1, 2022
Merged

feat(ctp): introduce Drippie#2569
mergify[bot] merged 1 commit intodevelopfrom
sc/drip

Conversation

@smartcontracts
Copy link
Contributor

@smartcontracts smartcontracts commented May 16, 2022 •
edited
Loading

Description
Drippie is a peripheral contract for automatically dripping ETH to
various other wallets securely.

@changeset-bot
Copy link

changeset-bot bot commented May 16, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 1f2a483

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eth-optimism/contracts-periphery Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mergify mergify bot requested review from Inphi and tuxcanfly May 16, 2022 23:03
@github-actions github-actions bot added 2-reviewers A-op-bindings Area: op-bindings labels May 16, 2022
Inphi
Inphi reviewed May 16, 2022
View reviewed changes
@mergify mergify bot requested a review from Inphi May 16, 2022 23:45
tynes
tynes reviewed May 17, 2022
View reviewed changes
@mergify
Copy link
Contributor

mergify bot commented May 17, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

@smartcontracts smartcontracts force-pushed the sc/drip branch 2 times, most recently from 3e5ba1f to ce0e66e Compare May 17, 2022 06:28
@smartcontracts smartcontracts marked this pull request as ready for review May 17, 2022 06:31
tynes
tynes reviewed May 17, 2022
View reviewed changes
tynes
tynes reviewed May 17, 2022
View reviewed changes
tynes
tynes reviewed May 17, 2022
View reviewed changes
@smartcontracts smartcontracts force-pushed the sc/drip branch 2 times, most recently from 70184d8 to 545487f Compare May 18, 2022 19:23
@smartcontracts smartcontracts changed the title feat(ctp): introduce DrippieRedd feat(ctp): introduce Drippie May 18, 2022
@smartcontracts smartcontracts force-pushed the sc/drip branch 9 times, most recently from 71f242d to b124247 Compare May 20, 2022 18:08
@mergify mergify bot added the conflict label May 26, 2022
@mergify mergify bot removed the conflict label May 26, 2022
@tynes
Copy link
Contributor

tynes commented May 26, 2022 

nused devDependencies
* lodash

Exited with code exit status 255

@smartcontracts smartcontracts force-pushed the sc/drip branch 2 times, most recently from f6a6bd0 to 23a7ba0 Compare May 27, 2022 17:43
maurelian
maurelian requested changes May 27, 2022
View reviewed changes
Copy link
Contributor

@maurelian maurelian left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside for my comments in the review, my only concern is that despite the presence of a slither.config.json file, it doesn't look like we're running slither on this package in CI.
I ran it locally, and the only issue I think needs to be addressed is declaring functions external where possible.

That said I don't think it's necessary for this PR to get it running in CI.

@smartcontracts smartcontracts force-pushed the sc/drip branch 3 times, most recently from d83fa7a to c70f634 Compare May 28, 2022 03:05
@smartcontracts
Copy link
Contributor Author

smartcontracts commented May 28, 2022

Aside for my comments in the review, my only concern is that despite the presence of a slither.config.json file, it doesn't look like we're running slither on this package in CI. I ran it locally, and the only issue I think needs to be addressed is declaring functions external where possible.

That said I don't think it's necessary for this PR to get it running in CI.

All feedback addressed. Added slither execution and included a few // slither-disable-next-line comments in areas where I felt the slither issue was not exploitable in our security model.

maurelian
maurelian approved these changes May 31, 2022
View reviewed changes
Copy link
Contributor

@maurelian maurelian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 comment, but generally LGTM

tynes
tynes requested changes May 31, 2022
View reviewed changes
Copy link
Contributor

@tynes tynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be downgrading the gitmodule forge-std

@smartcontracts
Copy link
Contributor Author

smartcontracts commented Jun 1, 2022

This seems to be downgrading the gitmodule forge-std

Fixed

@mergify
Copy link
Contributor

mergify bot commented Jun 1, 2022

Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Jun 1, 2022
@smartcontracts
feat(ctp): introduce Drippie and rework deploy
1f2a483 
Drippie is a helper contract for managing automatic contract
interactions. Drippie is meant to be deployed as a middle layer between
our contracts and other automation services like Gelato. This commit
also revamps the deployment process to use hardhat-deploy deterministic
deployments, ledger support, and better authentication.
@mergify mergify bot removed the conflict label Jun 1, 2022
@mergify
Copy link
Contributor

mergify bot commented Jun 1, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify mergify bot merged commit 416d2e6 into develop Jun 1, 2022
@mergify mergify bot deleted the sc/drip branch June 1, 2022 21:57
@mergify
Copy link
Contributor

mergify bot commented Jun 1, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

theochap pushed a commit that referenced this pull request Dec 10, 2025
@clabby
chore(protocol): Optional OpAttributesWithParent::derived_from field (
82da299 
#2569)

## Overview

Updates `OpAttributesWithParent` to have an _optional_ `derived_from`
field, rather than requiring it. When the sequencer builds attributes,
it provides `None`.

Also renames the field from `l1_origin` -> `derived_from` to reduce
confusion, as these are two strictly different concepts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tynes tynes tynes approved these changes

@maurelian maurelian maurelian approved these changes

@tuxcanfly tuxcanfly Awaiting requested review from tuxcanfly

@Inphi Inphi Awaiting requested review from Inphi

Assignees

No one assigned

Labels

A-op-bindings Area: op-bindings

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@smartcontracts @tynes @Inphi @maurelian