Conversation
Contributor
mslipper
commented
May 12, 2022
mslipper
commented
- fix(sdk): bug causing error when no tx nonce given (fix(sdk): bug causing error when no tx nonce given #2556)
- feat: add MaxPlaintextBatchSize parameter (feat: add MaxPlaintextBatchSize parameter #2557)
Fixes a bug in the SDK that would throw an error when the user did not provide a nonce along with the transaction (when estimating gas). If no nonce is provided, will try to find a reasonable nonce or use a default (large) nonce that will give a good upper bound for the L1 gas cost.
This allows the batch submitter to attempt to encode larger ranges of transactions before they are compressed and tested against the max tx size. Empirically this should give us ~3x throughput.
🦋 Changeset detectedLatest commit: b2aa08e The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
2-reviewers
A-ops
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.