Fix: make build for Apple Silicon by DanieleSalatti · Pull Request #2550 · ethereum-optimism/optimism

DanieleSalatti · 2022-05-08T23:49:20Z

Description
Fixing the build process on Mac with Apple Silicon.

Additional context
Building on M1 macs fails because of missing dependencies.

Metadata

Fixes Building Optimistic Ethereum locally fails #2429

I had the same issue as #2429, adding `eudev-dev` and `build-base` fixes it.

changeset-bot · 2022-05-08T23:49:23Z

⚠️ No Changeset found

Latest commit: f37c385

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

tynes · 2022-05-09T22:49:45Z

Does anybody have an m1 to test this out?

tuxcanfly · 2022-05-12T00:38:00Z

This fixes the issue with yarn install. But there's something else that's failing and I'm not sure if it's just me 😕

 => ERROR [base 17/17] RUN yarn build                                                                                                                                                                  17.9s
------
 > [base 17/17] RUN yarn build:
#21 0.782 yarn run v1.22.18
#21 0.812 $ yarn lerna run build
#21 1.043 $ /opt/optimism/node_modules/.bin/lerna run build
#21 1.454 lerna notice cli v4.0.0
#21 1.456 lerna info versioning independent
#21 1.504 lerna info Executing command in 9 packages: "yarn run build"
#21 6.684 lerna info run Ran npm script 'build' in '@eth-optimism/core-utils' in 5.2s:
#21 6.684 $ tsc -p tsconfig.build.json
#21 12.11 lerna info run Ran npm script 'build' in '@eth-optimism/common-ts' in 5.4s:
#21 12.11 $ tsc -p tsconfig.build.json
#21 17.00 lerna ERR! yarn run build exited 2 in '@eth-optimism/replica-healthcheck'
#21 17.00 lerna ERR! yarn run build stdout:
#21 17.00 $ tsc -p tsconfig.build.json
#21 17.00 src/service.ts(3,3): error TS2724: '"@eth-optimism/common-ts"' has no exported member named 'BaseServiceV2'. Did you mean 'BaseService'?
#21 17.00 src/service.ts(4,3): error TS2305: Module '"@eth-optimism/common-ts"' has no exported member 'Counter'.
#21 17.00 src/service.ts(5,3): error TS2305: Module '"@eth-optimism/common-ts"' has no exported member 'Gauge'.
#21 17.00 src/service.ts(6,3): error TS2305: Module '"@eth-optimism/common-ts"' has no exported member 'validators'.
#21 17.00 src/service.ts(90,33): error TS2339: Property 'options' does not exist on type 'HealthcheckService'.
#21 17.00 src/service.ts(93,14): error TS2339: Property 'logger' does not exist on type 'HealthcheckService'.
#21 17.00 src/service.ts(94,14): error TS2339: Property 'metrics' does not exist on type 'HealthcheckService'.
#21 17.00 src/service.ts(104,36): error TS2339: Property 'options' does not exist on type 'HealthcheckService'.
#21 17.00 src/service.ts(109,14): error TS2339: Property 'logger' does not exist on type 'HealthcheckService'.
#21 17.00 src/service.ts(110,14): error TS2339: Property 'metrics' does not exist on type 'HealthcheckService'.
#21 17.00 src/service.ts(122,10): error TS2339: Property 'metrics' does not exist on type 'HealthcheckService'.
#21 17.00 src/service.ts(123,10): error TS2339: Property 'metrics' does not exist on type 'HealthcheckService'.
#21 17.00 src/service.ts(124,10): error TS2339: Property 'metrics' does not exist on type 'HealthcheckService'.
#21 17.00 src/service.ts(126,10): error TS2339: Property 'logger' does not exist on type 'HealthcheckService'.
#21 17.00 src/service.ts(133,34): error TS2339: Property 'options' does not exist on type 'HealthcheckService'.
#21 17.00 src/service.ts(136,12): error TS2339: Property 'logger' does not exist on type 'HealthcheckService'.
#21 17.00 src/service.ts(142,31): error TS2339: Property 'options' does not exist on type 'HealthcheckService'.
#21 17.00 src/service.ts(145,12): error TS2339: Property 'logger' does not exist on type 'HealthcheckService'.
#21 17.00 src/service.ts(156,12): error TS2339: Property 'logger' does not exist on type 'HealthcheckService'.
#21 17.00 src/service.ts(164,12): error TS2339: Property 'logger' does not exist on type 'HealthcheckService'.
#21 17.00 src/service.ts(170,14): error TS2339: Property 'logger' does not exist on type 'HealthcheckService'.
#21 17.00 src/service.ts(171,35): error TS2339: Property 'options' does not exist on type 'HealthcheckService'.
#21 17.00 src/service.ts(172,35): error TS2339: Property 'options' does not exist on type 'HealthcheckService'.
#21 17.00 src/service.ts(181,12): error TS2339: Property 'logger' does not exist on type 'HealthcheckService'.
#21 17.00 src/service.ts(182,12): error TS2339: Property 'metrics' does not exist on type 'HealthcheckService'.
#21 17.00 src/service.ts(183,12): error TS2339: Property 'metrics' does not exist on type 'HealthcheckService'.
#21 17.00 src/service.ts(189,24): error TS2339: Property 'options' does not exist on type 'HealthcheckService'.
#21 17.00 src/service.ts(193,10): error TS2339: Property 'logger' does not exist on type 'HealthcheckService'.
#21 17.00 src/service.ts(198,10): error TS2339: Property 'metrics' does not exist on type 'HealthcheckService'.
#21 17.00 src/service.ts(199,10): error TS2339: Property 'metrics' does not exist on type 'HealthcheckService'.
#21 17.00 src/service.ts(205,11): error TS2339: Property 'run' does not exist on type 'HealthcheckService'.
#21 17.00 info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
#21 17.00 lerna ERR! yarn run build stderr:
#21 17.00 error Command failed with exit code 2.
#21 17.00 lerna ERR! yarn run build exited 2 in '@eth-optimism/replica-healthcheck'
#21 17.00 lerna WARN complete Waiting for 1 child process to exit. CTRL-C to exit immediately.
#21 17.21 error Command failed with exit code 2.
#21 17.21 info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
#21 17.39 error Command failed with exit code 2.
#21 17.39 info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
------
executor failed running [/bin/sh -c yarn build]: exit code: 2
ERROR: Service 'deployer' failed to build : Build failed

DanieleSalatti · 2022-05-12T00:59:01Z

@tuxcanfly I did not get that one.

Which commit are you on? I can take a look.

tuxcanfly · 2022-05-12T01:53:45Z

@DanieleSalatti I think it's something silly like outdated dependencies on my local.

@smartcontracts Any idea why this happens? I think I have a pretty clean build and I'm trying to yarn build in the replica-healthcheck package but seeing this:

yarn run v1.22.18
$ tsc -p tsconfig.build.json
src/service.ts:3:3 - error TS2724: '"@eth-optimism/common-ts"' has no exported member named 'BaseServiceV2'. Did you mean 'BaseService'?

3   BaseServiceV2,
    ~~~~~~~~~~~~~

  ../common-ts/dist/base-service.d.ts:13:22
    13 export declare class BaseService<T> {
                            ~~~~~~~~~~~
    'BaseService' is declared here.

src/service.ts:4:3 - error TS2305: Module '"@eth-optimism/common-ts"' has no exported member 'Counter'.

DanieleSalatti · 2022-05-13T14:06:58Z

@tuxcanfly I might have some time today to try this again from a clean clone, I will report back if I hit the same issue you are having and I'll try to look into it

Inphi

Looks good. The build-base package already contains the libev headers, so you can remove the evdev-dev dep.

smartcontracts · 2022-05-16T18:38:49Z

@DanieleSalatti I think it's something silly like outdated dependencies on my local.

@smartcontracts Any idea why this happens? I think I have a pretty clean build and I'm trying to yarn build in the replica-healthcheck package but seeing this:
yarn run v1.22.18
$ tsc -p tsconfig.build.json
src/service.ts:3:3 - error TS2724: '"@eth-optimism/common-ts"' has no exported member named 'BaseServiceV2'. Did you mean 'BaseService'?

3   BaseServiceV2,
    ~~~~~~~~~~~~~

  ../common-ts/dist/base-service.d.ts:13:22
    13 export declare class BaseService<T> {
                            ~~~~~~~~~~~
    'BaseService' is declared here.

src/service.ts:4:3 - error TS2305: Module '"@eth-optimism/common-ts"' has no exported member 'Counter'.

Can you try:

yarn clean
yarn build
cd ops
docker-compose build

tuxcanfly · 2022-05-16T18:57:26Z

@smartcontracts That worked! Sorry for holding up this PR, it was probably unrelated.

DanieleSalatti · 2022-05-17T03:55:27Z

Looks good. The build-base package already contains the libev headers, so you can remove the evdev-dev dep.

Done :)

DanieleSalatti · 2022-05-17T21:59:45Z

Merging from development

DanieleSalatti · 2022-05-23T01:48:03Z

@tuxcanfly @Inphi - quick ping for approval :)

Inphi

thanks!

mergify · 2022-05-23T01:53:26Z

This PR has been added to the merge queue, and will be merged soon.

mergify · 2022-05-23T01:53:41Z

This PR is next in line to be merged, and will be merged as soon as checks pass.

### Description Release artifacts for the `kona-node` release `v0.1.1`.

Fix: make build for Apple Silicon

29e310f

I had the same issue as #2429, adding `eudev-dev` and `build-base` fixes it.

github-actions bot added 2-reviewers A-ops Area: ops labels May 8, 2022

mergify bot requested review from Inphi and tuxcanfly May 8, 2022 23:49

Inphi reviewed May 16, 2022

View reviewed changes

mergify bot requested a review from Inphi May 16, 2022 15:57

Remove redundant eudev-dep from Dockerfile.packages

436fbac

DanieleSalatti added 2 commits May 16, 2022 21:11

Merge branch 'ethereum-optimism:develop' into patch-1

9a2bc9b

Merge branch 'develop' into patch-1

9060ad7

mslipper approved these changes May 18, 2022

View reviewed changes

Inphi approved these changes May 23, 2022

View reviewed changes

mergify bot added the on-merge-train label May 23, 2022

mergify bot requested a review from Inphi May 23, 2022 01:53

Merge branch 'develop' into patch-1

f37c385

mergify bot merged commit 262b0db into ethereum-optimism:develop May 23, 2022

DanieleSalatti deleted the patch-1 branch May 24, 2022 15:21

theochap pushed a commit that referenced this pull request Dec 10, 2025

release: kona-node v0.1.1 (#2550)

0d43738

### Description Release artifacts for the `kona-node` release `v0.1.1`.

Conversation

DanieleSalatti commented May 8, 2022

Uh oh!

changeset-bot bot commented May 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

tynes commented May 9, 2022

Uh oh!

tuxcanfly commented May 12, 2022

Uh oh!

DanieleSalatti commented May 12, 2022

Uh oh!

tuxcanfly commented May 12, 2022

Uh oh!

DanieleSalatti commented May 13, 2022

Uh oh!

Inphi left a comment

Choose a reason for hiding this comment

Uh oh!

smartcontracts commented May 16, 2022

Uh oh!

tuxcanfly commented May 16, 2022

Uh oh!

DanieleSalatti commented May 17, 2022

Uh oh!

DanieleSalatti commented May 17, 2022

Uh oh!

DanieleSalatti commented May 23, 2022

Uh oh!

Inphi left a comment

Choose a reason for hiding this comment

Uh oh!

mergify bot commented May 23, 2022

Uh oh!

mergify bot commented May 23, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

changeset-bot bot commented May 8, 2022 •

edited

Loading