fix: correct FailedDatabase counter for upsert_disbursement, expose api-server metrics#2548
Merged
mergify[bot] merged 3 commits intoethereum-optimism:developfrom May 6, 2022
Conversation
Previously we would always increment the counter instead of adding the number of failed upserts observed.
🦋 Changeset detectedLatest commit: ca7b766 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mslipper
approved these changes
May 5, 2022
cfromknecht
changed the title
cfromknecht
changed the title
Inphi
reviewed
May 6, 2022
Contributor
Inphi
left a comment
Inphi
left a comment
There was a problem hiding this comment.
There are two changesets. Shouldn't there be only one summarizing both changes?
Collaborator
|
Both changesets will be squashed by the changesets tool into one. |
Inphi
approved these changes
May 6, 2022
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously we would always increment the counter instead of adding the
number of failed upserts observed.
Metadata