Conversation
|
github-actions
bot
added
2-reviewers
A-integration
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
…#2546) ## Summary Changes the `--rpc.port` CLI flag in `kona-node` to be `--port` while maintaining backwards compatibility by keeping `--rpc.port` as an alias. ## Changes Made ### Code Changes - **Updated `bin/node/src/flags/rpc.rs`**: Changed the primary flag from `--rpc.port` to `--port` with `--rpc.port` as an alias - **Updated tests**: Modified test cases to use `--port` and added test coverage for the `--rpc.port` alias ### Documentation Updates - **Updated `bin/node/README.md`**: Changed all examples to use `--port` instead of `--rpc.port` - **Updated `docs/docs/pages/node/faq/ports.mdx`**: Updated port reference table to show `--port` - **Updated `docs/docs/pages/node/configuration.mdx`**: Updated CLI reference to show `--port` ## Backwards Compatibility ✅ **Fully backwards compatible** - existing configurations and scripts using `--rpc.port` will continue to work without any changes. - The `--rpc.port` flag remains functional as an alias - Environment variable `KONA_NODE_RPC_PORT` is unchanged - Default port value remains `9545` ## Usage Examples ### New recommended usage: ```bash kona-node node --port 5060 [other-flags...] ``` ### Legacy usage (still works): ```bash kona-node node --rpc.port 5060 [other-flags...] ``` ## Testing - ✅ Manual verification that both `--port` and `--rpc.port` work correctly - ✅ Updated unit tests to cover both flags - ✅ Build successfully completes - ✅ Help output shows `--port` as the primary flag ## Migration No migration required - this is a purely additive change. Users can: 1. Continue using `--rpc.port` (no changes needed) 2. Gradually migrate to `--port` for consistency 3. Update documentation/examples to use the new flag name Fixes the requirement to standardize the port flag naming while ensuring zero breaking changes. <!-- START COPILOT CODING AGENT TIPS --> --- 💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click [here](https://survey.alchemer.com/s3/8343779/Copilot-Coding-agent) to start the survey. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: refcell <21288394+refcell@users.noreply.github.com> Co-authored-by: refcell <abigger87@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@eth-optimism/contracts@0.5.23
@eth-optimism/sdk@1.1.3