feat: correct conf_remaining calculation#2541
feat: correct conf_remaining calculation#2541mergify[bot] merged 2 commits intoethereum-optimism:developfrom
Conversation
🦋 Changeset detectedLatest commit: 7fb8624 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This PR changes implementation code, but doesn't include a changeset. Did you forget to add one? |
mslipper
left a comment
mslipper
left a comment
There was a problem hiding this comment.
LGTM, just add a changeset.
Subtaction was being performed in the wrong order, causing underflow.
cfromknecht
force-pushed
the
teleportr-fixes
branch
from
3a5526f to
7fb8624
Compare
|
This PR has been added to the merge queue, and will be merged soon. |
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
| confsRemaining = blockNumber + 1 - | ||
| (teleport.Deposit.BlockNumber + s.numConfirmations) | ||
| confsRemaining = teleport.Deposit.BlockNumber + s.numConfirmations - | ||
| (blockNumber + 1) |
There was a problem hiding this comment.
Wierd thing is I was reading this code and in my head it looked correct to me at the time
There was a problem hiding this comment.
haha well it looked correct to me as well when i wrote the first time 😅
4 participants
Subtaction was being performed in the wrong order, causing underflow.
Metadata