maint: Move Go packages into root of repo, adopt go.work#2524
maint: Move Go packages into root of repo, adopt go.work#2524mergify[bot] merged 2 commits intodevelopfrom
Conversation
|
|
Hey @mslipper! This PR has merge conflicts. Please fix them before continuing review. |
- Adopts Go workspaces for future compatibility with the Bedrock move into the monorepo - Moves Go packages to the root of the repo in order to fix import paths - Rewrites existing Go import paths - Removes Stackman, since it's not needed anymore
mslipper
force-pushed
the
feat/go-workspaces
branch
from
fa7d769 to
5e3793f
Compare
|
Added do not merge so more people than 2 can approve. |
Inphi
left a comment
Inphi
left a comment
There was a problem hiding this comment.
LGTM!
If it builds, it builds
|
This PR has been added to the merge queue, and will be merged soon. |
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
1 similar comment
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
…nchronize task. move block building logic to build task (#2524) ## Description Attempt at cleaning-up the engine and restoring the behavior from pre-refactor https://github.com/op-rs/kona/pull/2388/files. In particular: - Split up the forkchoice task into separated build and synchronize logic. The synchronize logic is now closer to the pre #2388 state - Restore the build FCU method in the build task. Ensure that the side-effects match the pre-#2388 state - Audit the other tasks and ensure the composition (if any), follow the side-effects from #2388 - Remove the `Forkchoice` task from the `EngineTask`s.
4 participants
No description provided.