Skip to content

cleanup: Remove setProxyTarget function#2516

Merged
mergify[bot] merged 2 commits intoethereum-optimism:developfrom
lucadonnoh:develop
May 1, 2022
Merged

cleanup: Remove setProxyTarget function#2516
mergify[bot] merged 2 commits intoethereum-optimism:developfrom
lucadonnoh:develop

Conversation

@lucadonnoh
Copy link
Contributor

Description
Removed unnecessary setProxyTarget function and replaced it with AddressManager.setAddress

Metadata

@changeset-bot
Copy link

changeset-bot bot commented Apr 30, 2022

⚠️ No Changeset found

Latest commit: ae7cbe0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify
Copy link
Contributor

mergify bot commented Apr 30, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

@mergify mergify bot requested review from Inphi and tuxcanfly April 30, 2022 20:03
smartcontracts
smartcontracts previously approved these changes May 1, 2022
Copy link
Contributor

@smartcontracts smartcontracts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥 🔥

@mergify
Copy link
Contributor

mergify bot commented May 1, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented May 1, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify
Copy link
Contributor

mergify bot commented May 1, 2022

Merge failed. Please see automated check logs for more details.

@mergify
Copy link
Contributor

mergify bot commented May 1, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit cc0594c into ethereum-optimism:develop May 1, 2022
theochap pushed a commit that referenced this pull request Dec 10, 2025
…ks (#2516)

## Summary

Adds a GitHub Actions workflow to automatically manage stale pull
requests by closing them after 4 weeks of inactivity, while respecting
PRs that have the `M-prevent-stale` label.

## Changes

- **New workflow**: `.github/workflows/stale.yaml`
  - Runs daily at 02:00 UTC via cron schedule
  - Can be manually triggered via `workflow_dispatch`
  - Uses the official `actions/stale@v9` action

## Configuration

The workflow is configured to:
- **Only process pull requests** (not issues)
- **Mark PRs as stale** after 21 days of inactivity
- **Close stale PRs** after an additional 7 days (28 days total = 4
weeks)
- **Exempt PRs with `M-prevent-stale` label** from stale processing
- **Remove stale labels** when PRs become active again
- **Limit operations** to 30 per run to respect API rate limits

## Messages

Clear, informative messages are posted when:
- Marking a PR as stale (explains the process and how to prevent
closure)
- Closing a stale PR (explains how to reopen and prevent future closure)

## Permissions

The workflow has the minimal required permissions:
- `issues: write` 
- `pull-requests: write`

This follows the repository's existing patterns for scheduled workflows
and maintains consistency with other GitHub Actions configurations.

<!-- START COPILOT CODING AGENT TIPS -->
---

💡 You can make Copilot smarter by setting up custom instructions,
customizing its development environment and configuring Model Context
Protocol (MCP) servers. Learn more [Copilot coding agent
tips](https://gh.io/copilot-coding-agent-tips) in the docs.

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: refcell <21288394+refcell@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove setProxyTarget function

3 participants