Skip to content

Remove unused makeAddressManager test function#2515

Merged
mergify[bot] merged 2 commits intoethereum-optimism:developfrom
dawsbot:close-2510
Apr 29, 2022
Merged

Remove unused makeAddressManager test function#2515
mergify[bot] merged 2 commits intoethereum-optimism:developfrom
dawsbot:close-2510

Conversation

@dawsbot
Copy link
Contributor

@dawsbot dawsbot commented Apr 29, 2022

Description
Remove unused makeAddressManager function

Additional context
Minimal changes b/c the function is not used elsewhere

Metadata

@changeset-bot
Copy link

changeset-bot bot commented Apr 29, 2022

⚠️ No Changeset found

Latest commit: c06938c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dawsbot dawsbot changed the title Remove unused function Remove unused makeAddressManager test function Apr 29, 2022
@mergify mergify bot requested review from Inphi and mslipper April 29, 2022 23:06
@mergify
Copy link
Contributor

mergify bot commented Apr 29, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

@smartcontracts
Copy link
Contributor

Sick! Feel free to drop an address or ENS and I'll send you a hand-drawn contributor NFT. ❤️

@mergify
Copy link
Contributor

mergify bot commented Apr 29, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Apr 29, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit 8e75dbf into ethereum-optimism:develop Apr 29, 2022
@dawsbot dawsbot deleted the close-2510 branch April 30, 2022 04:39
@dawsbot
Copy link
Contributor Author

dawsbot commented Apr 30, 2022

@smartcontracts I am daws.eth

🙏

theochap pushed a commit that referenced this pull request Dec 10, 2025
## Overview

Fixes the prometheus address, should be the internal IP.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove unused makeAddressManager function

3 participants