maint(ct): clean up library tests#2513
Merged
mergify[bot] merged 2 commits intodevelopfrom May 3, 2022
Merged
Conversation
Cleans up tests for all Library contracts using same techniques as previous PRs.
|
mslipper
approved these changes
Apr 29, 2022
tynes
approved these changes
May 3, 2022
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Contributor
|
Merge failed. Please see automated check logs for more details. |
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
theochap
added a commit
that referenced
this pull request
Dec 10, 2025
…g level (#2513) ## Summary This PR addresses the logging and error handling for peer dialing failures in the p2p gossip crate by: 1. **Reducing log level** from `warn` to `debug` for "unable to dial peer" messages 2. **Adding structured error context** explaining why peer dialing failed 3. **Changing `can_dial` signature** to return detailed error information 4. **Propagating specific errors** to the log for better debugging ## Changes Made ### 1. New `DialError` enum with specific error variants: ```rust pub enum DialError { InvalidMultiaddr { addr: Multiaddr }, AlreadyDialing { peer_id: PeerId }, ThresholdReached { addr: Multiaddr }, PeerBlocked { peer_id: PeerId }, InvalidIpAddress { addr: Multiaddr }, AddressBlocked { ip: IpAddr }, SubnetBlocked { ip: IpAddr }, } ``` ### 2. Updated `ConnectionGate` trait signature: **Before:** ```rust fn can_dial(&mut self, peer_id: &Multiaddr) -> bool; ``` **After:** ```rust fn can_dial(&mut self, peer_id: &Multiaddr) -> Result<(), DialError>; ``` ### 3. Enhanced logging in `driver.rs`: **Before:** ```rust if !self.connection_gate.can_dial(&addr) { warn!(target: "gossip", "unable to dial peer"); return; } ``` **After:** ```rust if let Err(dial_error) = self.connection_gate.can_dial(&addr) { debug!(target: "gossip", "unable to dial peer: {}", dial_error); return; } ``` ## Benefits - **Reduced log noise**: Changed from `warn` to `debug` level - **Better debugging**: Specific error messages explain why dialing failed - **Structured error handling**: Errors are now typed and can be handled programmatically - **Improved troubleshooting**: Clear context for each failure scenario ## Example Error Messages - `Failed to extract PeerId from Multiaddr: /ip4/127.0.0.1/tcp/8080` - `Already dialing peer: 12D3KooWEyoppNCUx8Yx66oV9fJnriXwCcXwDDUA2kj6vnc6iDEp` - `Dial threshold reached for peer: /ip4/127.0.0.1/tcp/8080/p2p/...` - `IP address 192.168.1.100 is in a blocked subnet` ## Testing - All existing tests continue to pass - Added new test `test_dial_error_handling` to verify error propagation - Minimal changes with focused scope (77 insertions, 22 deletions across 6 files) This change maintains backward compatibility while significantly improving the debugging experience for p2p connection issues. > [!WARNING] > > <details> > <summary>Firewall rules blocked me from connecting to one or more addresses</summary> > > #### I tried to connect to the following addresses, but was blocked by firewall rules: > > - `107.21.251.55` > - `18.210.176.114` > - `184.72.129.189` > - `3.134.214.169` > - `3.146.117.118` > - `3.146.213.65` > - `3.148.100.173` > - `3.220.145.177` > - `3.231.11.52` > - `3.231.138.188` > - `34.65.107.0` > - `34.65.109.126` > - `34.65.173.88` > - `34.65.175.185` > - `34.65.202.239` > - `34.65.205.244` > - `34.65.229.245` > - `34.65.43.171` > - `52.14.30.39` > - `52.15.54.8` > - `54.198.153.150` > > If you need me to access, download, or install something from one of these locations, you can either: > > - Configure [Actions setup steps](https://gh.io/copilot/actions-setup-steps) to set up my environment, which run before the firewall is enabled > - Add the appropriate URLs or hosts to my [firewall allow list](https://gh.io/copilot/firewall-config) > > </details> <!-- START COPILOT CODING AGENT TIPS --> --- 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: theochap <80177219+theochap@users.noreply.github.com> Co-authored-by: refcell <abigger87@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cleans up tests for all Library contracts using same techniques as
previous PRs.