Skip to content

feat(cu): add util for getting chain ID#2509

Merged
mergify[bot] merged 2 commits intodevelopfrom
sc/cu-chain-id-util
Apr 30, 2022
Merged

feat(cu): add util for getting chain ID#2509
mergify[bot] merged 2 commits intodevelopfrom
sc/cu-chain-id-util

Conversation

@smartcontracts
Copy link
Contributor

Description
Adds a one-liner for getting chain ID given an ethers.Provider input.
Going to follow this PR up with a good first issue to use this util
wherever we're trying to get the chain ID.

Adds a one-liner for getting chain ID given an ethers.Provider input.
Going to follow this PR up with a good first issue to use this util
wherever we're trying to get the chain ID.
@changeset-bot
Copy link

changeset-bot bot commented Apr 29, 2022

🦋 Changeset detected

Latest commit: 1d131a0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@eth-optimism/core-utils Patch
@eth-optimism/common-ts Patch
@eth-optimism/contracts Patch
@eth-optimism/data-transport-layer Patch
@eth-optimism/message-relayer Patch
@eth-optimism/replica-healthcheck Patch
@eth-optimism/sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the A-pkg-core-utils Area: packages/core-utils label Apr 29, 2022
@mergify mergify bot requested review from Inphi and tuxcanfly April 29, 2022 16:44
Copy link
Contributor

@roninjin10 roninjin10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Added a suggestion if you thought it was a good idea for your use case.

@mergify mergify bot requested a review from Inphi April 29, 2022 21:27
@mergify
Copy link
Contributor

mergify bot commented Apr 29, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Apr 29, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit 6b9fc05 into develop Apr 30, 2022
@mergify mergify bot deleted the sc/cu-chain-id-util branch April 30, 2022 00:15
theochap added a commit that referenced this pull request Dec 10, 2025
…trics (#2509)

## Description

This PR:
- Tests `RollupConfig` rpc endpoint
- Fixes the rollup config metrics in grafana if the chain id is not part
of the scr
- Adds a test to ensure the other nodes of the network are lagging
behind the sequencer unsafe head
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-pkg-core-utils Area: packages/core-utils

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants