go/proxyd: Proxy requests using batch JSON-RPC#2480
Merged
mergify[bot] merged 3 commits intoethereum-optimism:developfrom May 2, 2022
Merged
go/proxyd: Proxy requests using batch JSON-RPC#2480mergify[bot] merged 3 commits intoethereum-optimism:developfrom
mergify[bot] merged 3 commits intoethereum-optimism:developfrom
Conversation
|
Contributor
|
Hey @Inphi! This PR has merge conflicts. Please fix them before continuing review. |
Contributor
|
This PR changes implementation code, but doesn't include a changeset. Did you forget to add one? |
Inphi
commented
Apr 19, 2022
Inphi
commented
Apr 19, 2022
Inphi
force-pushed
the
inphi/batch-causality
branch
from
ca1366a to
f10ebb6
Compare
Inphi
force-pushed
the
inphi/batch-causality
branch
from
f10ebb6 to
bba4660
Compare
Contributor
|
Hey @Inphi! This PR has merge conflicts. Please fix them before continuing review. |
Contributor
|
This PR changes implementation code, but doesn't include a changeset. Did you forget to add one? |
Inphi
force-pushed
the
inphi/batch-causality
branch
from
9257945 to
f5acf11
Compare
We forward several RPC request objects to upstreams using the JSON-RPC batch functionality. This should be more efficient than serialized RPC request proxying the round-trip latency of the remaining request objects are eliminated. A new server config, `max_upstream_batch_size`, is introduced to limit the number of RPC request objects in a single batch request. This is to avoid overloading upstream as proxyd may accept a large number of request objects in a single request by having a large `max_body_size_bytes` config value.
Inphi
force-pushed
the
inphi/batch-causality
branch
from
f5acf11 to
19a5563
Compare
mslipper
requested changes
Apr 29, 2022
Collaborator
|
Apart from that one request above, this LGTM. |
mslipper
approved these changes
May 1, 2022
cfromknecht
approved these changes
May 2, 2022
Contributor
cfromknecht
left a comment
cfromknecht
left a comment
There was a problem hiding this comment.
LGTM, looking forward to seeing this land! 🎉
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Merged
Merged
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
) ## Summary Updates doc comments in the `kona-protocol` crate to properly format code references with backticks so they render correctly in generated documentation. ## Problem Code references in doc comments like `[BlockInfo]` were not being rendered as code in the generated documentation because they lacked backticks. This made the documentation less readable and inconsistent with Rust documentation conventions. ## Solution Systematically updated all doc comments in the `kona-protocol` crate to format code references with backticks: - `[BlockInfo]` → `[`BlockInfo`]` - `[OpAttributesWithParent]` → `[`OpAttributesWithParent`]` - `[L2BlockInfo]` → `[`L2BlockInfo`]` - And many more... ## Changes - **33 files modified** across the `kona-protocol` crate - **76 code references** properly formatted with backticks - Automated approach using Python script to ensure consistency and reduce manual errors - All changes preserve existing functionality while improving documentation readability ## Examples **Before:** ```rust /// Create a new [OpAttributesWithParent] instance. /// Returns the [BlockInfo] for this block. ``` **After:** ```rust /// Create a new [`OpAttributesWithParent`] instance. /// Returns the [`BlockInfo`] for this block. ``` ## Verification - ✅ Documentation builds successfully (`cargo doc` passes) - ✅ Code compiles without issues (`cargo check` passes) - ✅ Generated HTML documentation properly renders code references with `<code>` tags - ✅ No functional changes to the codebase This improvement enhances the developer experience by making the API documentation more readable and following Rust documentation best practices. <!-- START COPILOT CODING AGENT TIPS --> --- 💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click [here](https://survey.alchemer.com/s3/8343779/Copilot-Coding-agent) to start the survey. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: refcell <21288394+refcell@users.noreply.github.com> Co-authored-by: refcell <abigger87@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We forward several RPC request objects to upstreams using the JSON-RPC
batch functionality. This should be more efficient than serialized RPC
request proxying the round-trip latency of the remaining request objects
are eliminated.
A new server config,
max_upstream_batch_size, is introduced to limitthe number of RPC request objects in a single batch request. This is to
avoid overloading upstream as proxyd may accept a large number of
request objects in a single request by having a large
max_body_size_bytesconfig value.